nixos/scion: init #298737
nixos/scion: init #298737
Conversation
MatthewCroughan
force-pushed
the
mc/scion-modules
branch
from
f57ff90
to
6d20e5d
Compare
MatthewCroughan
force-pushed
the
mc/scion-modules
branch
from
6d20e5d
to
5e9b389
Compare
There was a problem hiding this comment.
I know almost nothing about SCION, so this is not really a review, but from what I can tell the Nix/NixOS sauce looks good. (Also @MatthewCroughan is giving me way too much credit)
Could you add this to a README in the test directory? |
MatthewCroughan
force-pushed
the
mc/scion-modules
branch
2 times, most recently
from
61dcf55
to
d64045b
Compare
|
@roberth Done, I've added it in |
There was a problem hiding this comment.
@MatthewCroughan awesome job getting this push up! Its exciting to have the SCION modules and this freestanding test.
Had a couple of comments but overall I think this looks solid. I mentioned this for the control daemon but for all the daemons included here: Would it be possible to include a environment.etc."scion/<daemon>.conf".source = confFile;? Its really nice to have the unit files reference things in /etc instead of /nix/store 🙂
Running nix build .#nixosTests.scion-freestanding-deployment passes with flying colors 🚀
MatthewCroughan
force-pushed
the
mc/scion-modules
branch
from
d64045b
to
acb62fb
Compare
MatthewCroughan
force-pushed
the
mc/scion-modules
branch
from
acb62fb
to
d3ee5fe
Compare
These are the names of the binaries as they are distributed in some places. Upstream systemd services even depend upon these names, it is going to be helpful to keep this naming consistent, for bootstrapping
MatthewCroughan
force-pushed
the
mc/scion-modules
branch
from
d3ee5fe
to
716f10c
Compare
|
maybe add the test to passthru.tests on the scion package? |
Description of changes
Adds nixosModules and an extensive VM Test for the SCION internet architecture which implements a 5 autonomous system network topology based upon upstream documentation
Thanks to @roberth for help with figuring out how to structure the modules and their naming.
VM test topology
Goals for a future PR, not this PR
/etc/ssh/ssh_host*scion.enable = true)Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.