Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epub-thumbnailer: init at unstable-2024-03-16 #298771

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

GaetanLepage
Copy link
Contributor

Description of changes

Add epub-thumbnailer.
I went with the minimal (i.e. script only) installation.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@jopejoe1 jopejoe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some small nitpicks.

Maybe also add an update script

  passthru.updateScript = unstableGitUpdater { };

pkgs/by-name/ep/epub-thumbnailer/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ep/epub-thumbnailer/package.nix Outdated Show resolved Hide resolved
@GaetanLepage
Copy link
Contributor Author

passthru.updateScript = unstableGitUpdater { };

Done

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 25, 2024
@SuperSandro2000 SuperSandro2000 merged commit 82882fb into NixOS:master Mar 25, 2024
23 of 24 checks passed
@GaetanLepage GaetanLepage deleted the epub branch March 26, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants