Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

payme: 1.2.0 -> 1.2.1 #299210

Closed
wants to merge 1 commit into from
Closed

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/jovandeginste/payme/releases.

meta.description for payme is: QR code generator (ASCII & PNG) for SEPA payments

meta.homepage for payme is: https://github.com/jovandeginste/payme

Updates performed
  • Golang update
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.2.1 with grep in /nix/store/f7qz7r3wsx0xr7pds36r64x7g0bd8sff-payme-1.2.1
  • found 1.2.1 in filename of file in /nix/store/f7qz7r3wsx0xr7pds36r64x7g0bd8sff-payme-1.2.1

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
payme
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/f7qz7r3wsx0xr7pds36r64x7g0bd8sff-payme-1.2.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A payme https://github.com/r-ryantm/nixpkgs/archive/08189b240dc18edda2672d42a52c2efe817600bc.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/08189b240dc18edda2672d42a52c2efe817600bc#payme

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/f7qz7r3wsx0xr7pds36r64x7g0bd8sff-payme-1.2.1
ls -la /nix/store/f7qz7r3wsx0xr7pds36r64x7g0bd8sff-payme-1.2.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:
  • payme

Maintainer pings

cc @cimm for testing.

@cimm
Copy link
Contributor

cimm commented Mar 26, 2024

I tested the package, and it works as expected.

There is an ongoing discussion related to showing the date in the version string. I will add those changes soon, but I am unsure what the nix approach is here. Do we merge this pull request and open a new one with the changes, or do we reject this and do I open a pull request with all the changes?

To be clear, functionally this pull request works, it only does not show the build date in the payme --version output.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Mar 26, 2024
@wegank
Copy link
Member

wegank commented Mar 30, 2024

Since no one has merged it during the week despite the tag, I'll suggest creating another PR with the changes.

@wegank wegank marked this pull request as draft March 30, 2024 19:19
@cimm cimm closed this May 2, 2024
@r-ryantm r-ryantm deleted the auto-update/payme branch May 3, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants