Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vale-style-{microsoft,google,write-good,proselint,joblint,alex,readability}: init at various #299481

Closed
wants to merge 7 commits into from

Conversation

katexochen
Copy link
Contributor

@katexochen katexochen commented Mar 27, 2024

Description of changes

Adding different style packages for vale.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
@katexochen katexochen changed the title vale-syles-{microsoft,google,write-good,proselint,joblint,alex,readability}: init at various vale-style-{microsoft,google,write-good,proselint,joblint,alex,readability}: init at various Mar 27, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1569

@marsam
Copy link
Contributor

marsam commented Mar 31, 2024

Thanks for your contribution!

I was thinking that maybe we could group the styles in a valeStyles: https://github.com/marsam/nixpkgs/commit/c33908c1fd6dfa0e95efedb5b54f422141651ac0 (basic implementation)
What do you think?

@katexochen
Copy link
Contributor Author

I was thinking that maybe we could group the styles in a valeStyles: marsam@c33908c (basic implementation) What do you think?

Thanks @marsam, looks like a nice idea! Can you add the remaining styles of this PR and open a PR with your suggestion? I'm happy to review. :)

@katexochen katexochen marked this pull request as draft April 1, 2024 17:54
@katexochen
Copy link
Contributor Author

@marsam or do you want me to adapt that pattern in this PR?

@marsam
Copy link
Contributor

marsam commented Apr 3, 2024

@katexochen sorry for the delay. I created a PR with my approach #301204

@katexochen
Copy link
Contributor Author

Closed in favor of #301204

@katexochen katexochen closed this Apr 21, 2024
@katexochen katexochen deleted the vale/styles branch April 21, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants