Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.periodiq: Relax pendulum dependency #300086

Merged
merged 1 commit into from
Apr 18, 2024
Merged

python312Packages.periodiq: Relax pendulum dependency #300086

merged 1 commit into from
Apr 18, 2024

Conversation

traxys
Copy link
Contributor

@traxys traxys commented Mar 29, 2024 •
edited
Loading

Description of changes

Due to a pendulum update the perodiq build broke. The package still works while relaxing the dependency

Broken by #294305

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@traxys
Copy link
Contributor Author

traxys commented Mar 29, 2024

Result of nixpkgs-review pr 300086 run on x86_64-linux 1

10 packages built:
  • fit-trackee
  • fit-trackee.dist
  • python311Packages.flask-dramatiq
  • python311Packages.flask-dramatiq.dist
  • python311Packages.periodiq
  • python311Packages.periodiq.dist
  • python312Packages.flask-dramatiq
  • python312Packages.flask-dramatiq.dist
  • python312Packages.periodiq
  • python312Packages.periodiq.dist

@traxys traxys requested a review from wegank March 29, 2024 21:15
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 29, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3786

sarahec
sarahec suggested changes Apr 14, 2024
View reviewed changes
Copy link
Contributor

@sarahec sarahec left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to pin this to the tested API version (^3.0 instead of *)

sarahec
sarahec reviewed Apr 14, 2024
View reviewed changes
Copy link
Contributor

@sarahec sarahec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Python tests pass. nixpkgs-review passes.

@leona-ya leona-ya merged commit d9ec9a3 into NixOS:master Apr 18, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahec sarahec sarahec requested changes

@leona-ya leona-ya leona-ya approved these changes

@wegank wegank Awaiting requested review from wegank

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@traxys @nixos-discourse @leona-ya @sarahec