element-call: init at 0.5.16; lk-jwt-service: init at main #300966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilimnik
changed the title
kilimnik
force-pushed
the
element-call
branch
2 times, most recently
from
11d5f1b
to
a7788fe
Compare
ofborg
bot
added
8.has: package (new)
| +++ b/package.json | ||
| @@ -1,4 +1,5 @@ | ||
| { | ||
| + "name": "element-call", |
There was a problem hiding this comment.
Please try to upstream this diff
| ''; | ||
|
|
||
| offlineCache = fetchYarnDeps { | ||
| yarnLock = "${src}/yarn.lock"; |
There was a problem hiding this comment.
That could be triggering IFD, you are sure it does not?
There was a problem hiding this comment.
I'm not sure, though this is what the documentation recommends doing
|
I have updated the package and will wait for the CI to build the backages on aarch64 as well as darwin to get the corresponding hashes |
kilimnik
changed the title
SuperSandro2000
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Package the element-call software, as well as the lk-jwt-service. Element Call is a web group calling application, which uses lk-jwt-service as it's authentication service.
As these packages are designed to work side by side, I thought it would make sense, to have only one PR. If necessary I can split those up.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.