Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syslogng: fix build failure related to setuptools #301741

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

pmiddend
Copy link
Contributor

@pmiddend pmiddend commented Apr 5, 2024

Description of changes

Latest unstable syslogng fails with this error (see hydra):

syslog-ng> /nix/store/a1s263pmsci9zykm5xcdf7x9rv26w6d5-bash-5.2p26/bin/bash /build/source/install-sh -d //nix/store/3r2gf24fyqk3g2w8wdj3mx0i4x038vkg-syslog-ng-4.6.0/share/syslog-ng/include/scl
syslog-ng> Traceback (most recent call last):
syslog-ng>   File "/build/source/modules/python-modules/setup.py", line 24, in <module>
syslog-ng>     from setuptools import setup
syslog-ng> ModuleNotFoundError: No module named 'setuptools'

So setuptools was missing, I added it, now it builds.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pmiddend pmiddend requested a review from vifino April 5, 2024 06:37
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 5, 2024
Copy link
Member

@vifino vifino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did it build before without issues?
Regardless, this seems like a working fix.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Apr 7, 2024
@7c6f434c 7c6f434c merged commit 632c6b8 into NixOS:master Apr 7, 2024
31 checks passed
@pmiddend pmiddend deleted the syslogng-build-fix branch April 8, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants