gitg: 41 -> 44

[Luflosi]

Description of changes

https://download.gnome.org/sources/gitg/44/gitg-44.news

Also:

• Add myself as a maintainer
• Enable strictDeps
• Run the tests again since they now work
• Use --replace-fail instead of --replace for substituteInPlace

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[amaxine]

Also included in #291339.

[Luflosi]

Ah, a GitHub search for "gitg" didn't find that.
How should we best combine our changes into one commit? Each of the two commits has improvements not included in the other.

[amaxine]

@Luflosi feel free to integrate the changes from the gnome-46 branch into this PR, or PR your changes to the gnome-46 branch, whichever works for you. I don't believe this is actively blocked on anything that's included in the gnome-46 branch, so whichever way you prefer is good.

[Luflosi]

I updated my PR to also remove adwaita-icon-theme like in the gnome-46 branch.

This PR should now be a strict superset of the commit in the gnome-46 branch.

[amaxine]

I'll make a note to drop the commit from gnome-46 during next rebase.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3796

[amaxine]

I think this is missing gvfs as a dep, or possibly is a side effect of me running it on my gnome 46 system and it doesn't like newer gvfs.

/nix/store/39vd62yh0j8zgrm20f9rv2mwynq7gs0j-gvfs-1.54.0/lib/gvfs/libgvfscommon.so: undefined symbol: g_once_init_leave_pointer
Failed to load module: /nix/store/39vd62yh0j8zgrm20f9rv2mwynq7gs0j-gvfs-1.54.0/lib/gio/modules/libgvfsdbus.so

[Luflosi]

I added gvfs as a dependency. Can you please check if you still have the same problem?

[amaxine]

I built it that way locally before leaving the comment, so yes 😅

[Luflosi]

Okay, thank you.
So this should be ready for merging, right?

[Luflosi]

Thanks!