Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

juicefs: fix build #302005

Merged
merged 1 commit into from
Apr 7, 2024
Merged

juicefs: fix build #302005

merged 1 commit into from
Apr 7, 2024

Conversation

sedlund
Copy link
Member

@sedlund sedlund commented Apr 6, 2024

Description of changes

JuiceFS 1.1.2 fails to compile with Go 1.22. - juicedata/juicefs#4339

So use Go 1.21

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dit7ya


Add a 👍 reaction to pull requests you find important.

@Aleksanaa
Copy link
Member

Please squash your commits.

@Aleksanaa Aleksanaa merged commit 27298ef into NixOS:master Apr 7, 2024
23 of 24 checks passed
@sedlund sedlund deleted the fix/juicefs_build branch April 7, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants