Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightningcss: 1.24.0 -> 1.24.1 #302174

Merged
merged 1 commit into from
Apr 10, 2024
Merged

lightningcss: 1.24.0 -> 1.24.1 #302174

merged 1 commit into from
Apr 10, 2024

Conversation

JohnRTitor
Copy link
Contributor

@JohnRTitor JohnRTitor commented Apr 6, 2024 •
edited
Loading

Description of changes

lightningcss: 1.24.0 -> 1.24.1 - Changelog

Additionally patch ./napi/Cargo.toml to allow building lightningcss-napi. See parcel-bundler/lightningcss#713 parcel-bundler/lightningcss#702.

Without this patch, v1.24.1 won't build at all since an entire dependency napi was added in this release.

Closes #296639.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Pinging maintainer: @toastal

Add a 👍 reaction to pull requests you find important.

@JohnRTitor
lightningcss: 1.24.0 -> 1.24.1
5af750a 
Additionally patch ./napi/Cargo.toml to allow building lightningcss-napi
parcel-bundler/lightningcss#713
parcel-bundler/lightningcss#702
@JohnRTitor JohnRTitor mentioned this pull request Apr 6, 2024
Closed
1 task
@toastal
Copy link
Contributor

toastal commented Apr 6, 2024 via email

@JohnRTitor
Copy link
Contributor Author

Result of nixpkgs-review pr 302174 run on x86_64-linux 1

1 package built:
  • lightningcss

@ofborg ofborg bot requested a review from toastal April 6, 2024 21:02
Gerg-L
Gerg-L approved these changes Apr 6, 2024
View reviewed changes
Copy link
Contributor

@Gerg-L Gerg-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, builds and runs on x86_64-linux!

@Gerg-L Gerg-L added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approvals: 1 This PR was reviewed and approved by one reputable person and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Apr 6, 2024
toastal
toastal approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@toastal toastal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built for me. Still wild to me that this was done in a patch version of lightningcss.

@JohnRTitor
Copy link
Contributor Author

JohnRTitor commented Apr 7, 2024 •
edited
Loading

Built for me. Still wild to me that this was done in a patch version of lightningcss.

Patch is made to the build instructions (Cargo.toml), no change has been made to the codebase. Upstream maintainer simply did not test the build on cargo auditable carefully.

@JohnRTitor
Copy link
Contributor Author

JohnRTitor commented Apr 7, 2024 •
edited
Loading

@toastal Would you be okay with me co-maintaining this package with you? I will add myself as a maintainer if you are okay with it.

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Apr 7, 2024
@toastal
Copy link
Contributor

toastal commented Apr 8, 2024 via email

@JohnRTitor JohnRTitor mentioned this pull request Apr 8, 2024
Merged
2 tasks
@Mic92 Mic92 merged commit 042af1d into NixOS:master Apr 10, 2024
42 checks passed
@JohnRTitor JohnRTitor deleted the lightningcss branch April 10, 2024 08:45
@bugeats
Copy link

bugeats commented May 10, 2024 •
edited
Loading

While trying to cross-compile for aarch64:

Executing cargoCheckHook
++ cargo test -j 24 --profile release --features=cli --target aarch64-unknown-linux-gnu --frozen --lib -- --test-threads=24
...
error: linker `aarch64-linux-gnu-gcc` not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerg-L Gerg-L Gerg-L approved these changes

@toastal toastal toastal approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: lightningcss 1.24.0 → 1.24.1
6 participants
@JohnRTitor @toastal @bugeats @Gerg-L @Mic92 @wegank