-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ollama: 0.1.30 -> 0.1.31 #303708
ollama: 0.1.30 -> 0.1.31 #303708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
, config | ||
# one of `[ null "rocm" "cuda" ]` | ||
, acceleration ? null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd consider adding the explicit false
variant which would produce the cpu-only ollama regardless of nixpkgs' instantiation. It can be confusing that (import <nixpkgs> { config.cudaSupport = true }).ollama.override { acceleration = null; }
still produces the cuda variant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A side note on this name: if we happen to add a package named "acceleration" at some point, this is going to break eval:) It might be prudent to change it early, say ollamaAcceleration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep the nixos option named the same as the package parameter if at all possible. Are there any rules on package naming across all of nixpkgs? Such as no underscores, only dashes, or anything along those lines? So I can figure out a nice name that would be fitting and that won't cause conflicts in the future.
37c3bf6
to
4508b59
Compare
Description of changes
Update ollama to 0.1.31, as well as defaulting to
config.rocmSupport
orconfig.cudaSupport
ifacceleration
isn't specified.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.