Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.11] mbedtls_2: 2.28.7 -> 2.28.8, mbedtls: add patch for CVE-2024-28755 #303874

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Apr 13, 2024

Description of changes

This is a partial backport of #300629. Straightforward for mbedtls_2, but for 3.x they've helpfully only included the fixes in a release that introduces some API breakage. It's only easy to fish out the patch for one of the issues. This is better than nothing though.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@risicle risicle added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Apr 13, 2024
@ofborg ofborg bot requested a review from raphaelr April 13, 2024 18:24
@risicle risicle marked this pull request as ready for review April 14, 2024 01:33
Copy link
Contributor

@raphaelr raphaelr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 303874 run on x86_64-linux 1

1 package marked as broken and skipped:
  • obs-studio-plugins.obs-hyperion
201 packages built:
  • bctoolbox
  • belcard
  • belle-sip
  • belr
  • bzrtp
  • dillo
  • dillong
  • dislocker
  • dolphin-emu
  • dolphin-emu-primehack
  • gauche
  • gaucheBootstrap
  • hashlink
  • haxe (haxe_4_2)
  • haxePackages.format
  • haxePackages.heaps
  • haxePackages.hlopenal
  • haxePackages.hlsdl
  • hxcpp (haxePackages.hxcpp)
  • haxePackages.hxcs
  • haxePackages.hxjava
  • haxePackages.hxnodejs_4
  • haxe_4_0
  • haxe_4_1
  • hiawatha
  • hyperion-ng
  • imhex
  • kodiPackages.libretro-2048
  • kodiPackages.libretro-fuse
  • kodiPackages.libretro-genplus
  • kodiPackages.libretro-mgba
  • kodiPackages.libretro-nestopia
  • kodiPackages.libretro-snes9x
  • ledfx
  • ledfx.dist
  • liblinphone
  • libosmoabis
  • libretro.atari800
  • libretro.beetle-gba
  • libretro.beetle-lynx
  • libretro.beetle-ngp
  • libretro.beetle-pce
  • libretro.beetle-pce-fast
  • libretro.beetle-pcfx
  • libretro.beetle-psx
  • libretro.beetle-psx-hw
  • libretro.beetle-saturn
  • libretro.beetle-supafaust
  • libretro.beetle-supergrafx
  • libretro.beetle-vb
  • libretro.beetle-wswan
  • libretro.blastem
  • libretro.bluemsx
  • libretro.bsnes
  • libretro.bsnes-hd
  • libretro.bsnes-mercury
  • libretro.bsnes-mercury-balanced
  • libretro.bsnes-mercury-performance
  • libretro.citra
  • libretro.desmume
  • libretro.desmume2015
  • libretro.dolphin
  • libretro.dosbox
  • libretro.dosbox-pure
  • libretro.eightyone
  • libretro.fbalpha2012
  • libretro.fbneo
  • libretro.fceumm
  • libretro.flycast
  • libretro.fmsx
  • libretro.freeintv
  • libretro.fuse
  • libretro.gambatte
  • libretro.genesis-plus-gx
  • libretro.gpsp
  • libretro.gw
  • libretro.handy
  • libretro.hatari
  • libretro.mame
  • libretro.mame2000
  • libretro.mame2003
  • libretro.mame2003-plus
  • libretro.mame2010
  • libretro.mame2015
  • libretro.mame2016
  • libretro.melonds
  • libretro.mesen
  • libretro.mesen-s
  • libretro.meteor
  • libretro.mgba
  • libretro.mupen64plus
  • libretro.neocd
  • libretro.nestopia
  • libretro.np2kai
  • libretro.nxengine
  • libretro.o2em
  • libretro.opera
  • libretro.parallel-n64
  • libretro.pcsx-rearmed
  • libretro.pcsx2
  • libretro.picodrive
  • libretro.play
  • libretro.ppsspp
  • libretro.prboom
  • libretro.prosystem
  • libretro.puae
  • libretro.quicknes
  • libretro.same_cdi
  • libretro.sameboy
  • libretro.scummvm
  • libretro.smsplus-gx
  • libretro.snes9x
  • libretro.snes9x2002
  • libretro.snes9x2005
  • libretro.snes9x2005-plus
  • libretro.snes9x2010
  • libretro.stella
  • libretro.stella2014
  • libretro.swanstation
  • libretro.tgbdual
  • libretro.thepowdertoy
  • libretro.tic80
  • libretro.twenty-fortyeight
  • libretro.vba-m
  • libretro.vba-next
  • libretro.vecx
  • libretro.virtualjaguar
  • libretro.yabause
  • librist
  • libubox-mbedtls
  • lime
  • linphone
  • lutris
  • lutris-free
  • mbedtls
  • mbedtls_2
  • mediastreamer
  • mediastreamer-openh264
  • msilbc
  • nanomq
  • neko
  • nng
  • obs-studio
  • obs-studio-plugins.advanced-scene-switcher
  • obs-studio-plugins.droidcam-obs
  • obs-studio-plugins.input-overlay
  • obs-studio-plugins.looking-glass-obs
  • obs-studio-plugins.obs-3d-effect
  • obs-studio-plugins.obs-backgroundremoval
  • obs-studio-plugins.obs-command-source
  • obs-studio-plugins.obs-freeze-filter
  • obs-studio-plugins.obs-gradient-source
  • obs-studio-plugins.obs-gstreamer
  • obs-studio-plugins.obs-livesplit-one
  • obs-studio-plugins.obs-move-transition
  • obs-studio-plugins.obs-multi-rtmp
  • obs-studio-plugins.obs-mute-filter
  • obs-studio-plugins.obs-nvfbc
  • obs-studio-plugins.obs-pipewire-audio-capture
  • obs-studio-plugins.obs-replay-source
  • obs-studio-plugins.obs-rgb-levels-filter
  • obs-studio-plugins.obs-scale-to-sound
  • obs-studio-plugins.obs-shaderfilter
  • obs-studio-plugins.obs-source-clone
  • obs-studio-plugins.obs-source-record
  • obs-studio-plugins.obs-source-switcher
  • obs-studio-plugins.obs-teleport
  • obs-studio-plugins.obs-text-pthread
  • obs-studio-plugins.obs-transition-table
  • obs-studio-plugins.obs-tuna
  • obs-studio-plugins.obs-vaapi
  • obs-studio-plugins.obs-vertical-canvas
  • obs-studio-plugins.obs-vintage-filter
  • obs-studio-plugins.obs-vkcapture
  • obs-studio-plugins.obs-websocket
  • obs-studio-plugins.waveform
  • obs-studio-plugins.wlrobs
  • openrgb
  • openrgb-with-all-plugins
  • ortp
  • osmo-bsc
  • osmo-bts
  • osmo-hlr
  • osmo-hnbgw
  • osmo-hnodeb
  • osmo-mgw
  • osmo-msc
  • osmo-sgsn
  • ps3netsrv
  • python310Packages.python-mbedtls
  • python310Packages.python-mbedtls.dist
  • python311Packages.python-mbedtls
  • python311Packages.python-mbedtls.dist
  • retroarch
  • retroarchBare
  • retroarchFull
  • shadowsocks-libev
  • srsran
  • trx
  • ustream-ssl-mbedtls
  • yojimbo

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Apr 15, 2024
@risicle risicle merged commit 1c75acb into NixOS:release-23.11 Apr 16, 2024
29 of 30 checks passed
Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Made almost complete runs of nixpkgs-review on Linux x86_64 and aarch64, no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants