Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genericUpdater: fix ignoredVersions #304059

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

midchildan
Copy link
Member

@midchildan midchildan commented Apr 14, 2024

Description of changes

ignoredVersions silently failed if GNU grep was not in PATH. I encountered this problem when running meta.updateScript for packages in my own flake.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

ignoredVersions silently failed if GNU grep was not in `PATH`.
@midchildan midchildan added 0.kind: bug 6.topic: updaters Tooling for (semi-)automated updating of packages labels Apr 14, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4135

@h7x4 h7x4 requested a review from romildo June 24, 2024 07:41
@h7x4 h7x4 merged commit e6951ae into NixOS:master Jun 24, 2024
27 checks passed
@midchildan midchildan deleted the fix/generic-updater/ignored-versions branch June 24, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants