Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.certomancer 0.11.0 -> 0.12.0 #304985

Closed
wants to merge 1 commit into from

Conversation

djacu
Copy link
Member

@djacu djacu commented Apr 18, 2024

Description of changes

Bumped version to 0.12.0 and disabled 1 broken test.

Several tests are broken on Python 3.12 and there is an open issue to fix it.
MatthiasValvekens/certomancer#12

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@djacu djacu force-pushed the zhf-python312-certomancer-bump-fix branch from 89c9784 to e717533 Compare April 18, 2024 06:08
@fabaff
Copy link
Member

fabaff commented Apr 18, 2024

Result of nixpkgs-review pr 304985 run on x86_64-linux 1

12 packages failed to build:
  • maigret
  • maigret.dist
  • python311Packages.pyhanko
  • python311Packages.pyhanko.dist
  • python311Packages.xhtml2pdf
  • python311Packages.xhtml2pdf.dist
  • python312Packages.pyhanko
  • python312Packages.pyhanko.dist
  • python312Packages.xhtml2pdf
  • python312Packages.xhtml2pdf.dist
  • sasview
  • sasview.dist
4 packages built:
  • python311Packages.certomancer
  • python311Packages.certomancer.dist
  • python312Packages.certomancer
  • python312Packages.certomancer.dist

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3850

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 30, 2024
@Moraxyc
Copy link
Contributor

Moraxyc commented May 27, 2024

Result of nixpkgs-review pr 304985 run on x86_64-linux 1

12 packages failed to build:
  • maigret
  • maigret.dist
  • python311Packages.pyhanko
  • python311Packages.pyhanko.dist
  • python311Packages.xhtml2pdf
  • python311Packages.xhtml2pdf.dist
  • python312Packages.pyhanko
  • python312Packages.pyhanko.dist
  • python312Packages.xhtml2pdf
  • python312Packages.xhtml2pdf.dist
  • sasview
  • sasview.dist
4 packages built:
  • python311Packages.certomancer
  • python311Packages.certomancer.dist
  • python312Packages.certomancer
  • python312Packages.certomancer.dist

@Moraxyc Moraxyc added backport release-24.05 Backport PR automatically 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign labels May 27, 2024
@risicle
Copy link
Contributor

risicle commented May 27, 2024

Hold on, what makes us think this is just "broken tests" on 3.12 and not breakage of the features behind them?

@Moraxyc
Copy link
Contributor

Moraxyc commented May 27, 2024

After reviewing the changes upstream and related resources, I think we cannot take this issue lightly.

asn1crypto removed .hash_algo for safety reasons, but there hasn’t been a release since that change. Consequently, the package in Nixpkgs has two versions of it. When we use Python 3.12, it includes an unstable version with the patch.

I believe a better approach is to disable the certomancer build on Python 3.12 until asn1crypto releases a new version and certomancer catches up.

Sorry for linking it to ZHF without sufficient consideration.

@Moraxyc Moraxyc removed 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign backport release-24.05 Backport PR automatically labels May 27, 2024
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels May 29, 2024
@GaetanLepage
Copy link
Contributor

I opened #315532 and then discovered this PR.
It looks like it addresses most of the concerns raised above.
Feel free to either pick changes from it (and close it) or merge it directly.

@Moraxyc Moraxyc self-requested a review May 29, 2024 07:21
@Moraxyc Moraxyc added 12.approvals: 1 This PR was reviewed and approved by one reputable person and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants