Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmltoman: init at 0.6 #305096

Merged
merged 1 commit into from
Jun 6, 2024
Merged

xmltoman: init at 0.6 #305096

merged 1 commit into from
Jun 6, 2024

Conversation

Tochiaha
Copy link
Contributor

@Tochiaha Tochiaha commented Apr 18, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Tochiaha Tochiaha mentioned this pull request Apr 18, 2024
Draft
13 tasks
@Tochiaha Tochiaha changed the title Xmltoman: init at 0.6 xmltoman: init at 0.6 Apr 18, 2024
Aleksanaa
Aleksanaa reviewed Apr 19, 2024
View reviewed changes
pkgs/by-name/xm/xmltoman/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xm/xmltoman/package.nix Outdated
perl538Packages.XMLTokeParser
];

buildPhase = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split postPatch buildPhase and preInstall.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't resolve this. Also overriding phases need adding runHook: runHook preBuild and runHook postBuild

Copy link
Contributor Author

@Tochiaha Tochiaha Apr 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean i did not resolve it by splitting it into buildPhase and preInstall? if so which part goes into preInstall?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look into this carefully. You can put all these to installPhase.

pkgs/by-name/xm/xmltoman/package.nix Outdated Show resolved Hide resolved
@Tochiaha Tochiaha force-pushed the xmltoman branch 5 times, most recently from 003bef2 to d861e9a Compare April 20, 2024 03:14
@9glenda
Copy link
Member

9glenda commented Apr 20, 2024

Result of nixpkgs-review pr 305096 run on x86_64-linux 1

1 package failed to build:
  • xmltoman

@Tochiaha Tochiaha force-pushed the xmltoman branch 6 times, most recently from 1cf25db to c49813c Compare April 21, 2024 19:09
@Tochiaha Tochiaha requested a review from Aleksanaa April 21, 2024 19:10
@Tochiaha Tochiaha force-pushed the xmltoman branch 2 times, most recently from 130e2a3 to 90fb088 Compare April 23, 2024 00:42
@Tochiaha
Copy link
Contributor Author

@fabaff any help here?

Aleksanaa
Aleksanaa reviewed Apr 24, 2024
View reviewed changes
pkgs/by-name/xm/xmltoman/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xm/xmltoman/package.nix Outdated
perl538Packages.XMLTokeParser
];

buildPhase = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't resolve this. Also overriding phases need adding runHook: runHook preBuild and runHook postBuild

@Tochiaha Tochiaha force-pushed the xmltoman branch 3 times, most recently from 86c9b29 to b8b942d Compare April 27, 2024 12:08
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3838

@Tochiaha Tochiaha requested a review from Aleksanaa April 30, 2024 04:34
SuperSandro2000
SuperSandro2000 reviewed Jun 2, 2024
View reviewed changes
pkgs/by-name/xm/xmltoman/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xm/xmltoman/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xm/xmltoman/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xm/xmltoman/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xm/xmltoman/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/xm/xmltoman/package.nix Show resolved Hide resolved
@kirillrdy kirillrdy merged commit 272d743 into NixOS:master Jun 6, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirillrdy kirillrdy kirillrdy left review comments

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Tochiaha @9glenda @nixos-discourse @kirillrdy @SuperSandro2000 @Aleksanaa