-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dub-to-nix,buildDubPackage: allow git-type dependencies #305582
Conversation
e26965c
to
6538b17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dub-to-nix
succeeds in generating the lockfile for Sideloader locally on my machine. Thank you @TomaSajt for such a quick response and fix ❤️
@tomodachi94 by the way, are you planning on adding the Sideloader package to Nixpkgs? |
6538b17
to
0c39d8a
Compare
Yes, I was, but feel free to PR it in yourself since you've packaged it already (though I am interested in being on the maintainers list). |
I think it's better if you open the PR yourself, as that package out of scope for this PR and I don't have any IOS devices. By the way, I also tried using |
0c39d8a
to
c4622d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapproving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, thanks
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1598 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Nix part LGTM and while I'm not qualified to review the other parts, I don't see any obvious issues.
If nobody objects, I'm inclined to merge :)
c4622d9
to
eaab342
Compare
Result of 8 packages built:
|
Description of changes
Closes: #305440
This PR adds support to
dub-to-nix
for processing other types of entries indub.selections.json
.It will now be able to parse and prefetch git-type dependencies and it will filter out
path
type dependencies.The custom lockfile format is only extended, so no breaking changes for previously generated lockfiles.
I also added the relevant logic to
buildDubPackage
that copies the directory fetched byfetchgit
to the appropriate location.The PR only causes rebuilds for other packages because of comment/whitespace differences in buildDubPackage. Other than this, other packages should be unaffected.
I temporarily added thesideloader
package's derivation to the PR to show that it works.Edit: I've removed it.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.