Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{SDL2_mixer,SDL2_net}: adopted by AndersonTorres #307078

Closed
wants to merge 1 commit into from
Closed

{SDL2_mixer,SDL2_net}: adopted by AndersonTorres #307078

wants to merge 1 commit into from

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Apr 26, 2024

Description of changes

Since @MP2E is away.

#290642

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Apr 26, 2024
@AndersonTorres AndersonTorres marked this pull request as ready for review April 26, 2024 23:14
@Aleksanaa
Copy link
Member

The package files are not moved but deleted and created. Could you check it again?

@AndersonTorres
Copy link
Member Author

The package files are not moved but deleted and created. Could you check it again?

This is how Git works, unfortunately. It renders big changes as "delete-then-recreate".

If you look at each individual commit, you will see clearly the files being explicitly moved instead of deleted-then-recreated.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3844

A team dedicated to track SDL libraries.
@AndersonTorres
Copy link
Member Author

I will reopen this later.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild and removed 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants