Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tuifimanager: 4.0.0 -> 4.0.5 #307438

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for tuifimanager is: A cross-platform terminal-based termux-oriented file manager

meta.homepage for tuifimanager is: https://github.com/GiorgosXou/TUIFIManager

meta.changelog for tuifimanager is: https://github.com/GiorgosXou/TUIFIManager/blob/refs/tags/v4.0.5/CHANGELOG.md

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 4.0.5 with grep in /nix/store/06bmrva8zg5msxv27ia9g6ba5j91rc81-tuifimanager-4.0.5
  • found 4.0.5 in filename of file in /nix/store/06bmrva8zg5msxv27ia9g6ba5j91rc81-tuifimanager-4.0.5

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

tuifimanager
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/06bmrva8zg5msxv27ia9g6ba5j91rc81-tuifimanager-4.0.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A tuifimanager https://github.com/r-ryantm/nixpkgs/archive/5de554215db9c4d7e0fb48d8403f8441cd94b5d1.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/5de554215db9c4d7e0fb48d8403f8441cd94b5d1#tuifimanager

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/06bmrva8zg5msxv27ia9g6ba5j91rc81-tuifimanager-4.0.5
ls -la /nix/store/06bmrva8zg5msxv27ia9g6ba5j91rc81-tuifimanager-4.0.5/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

2 packages built:
  • tuifimanager
  • tuifimanager.dist

Maintainer pings

cc @michaelBelsanti @Sigmanificient for testing.

Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog.md is officially depreciated thus it should be removed from meta
See: GiorgosXou/TUIFIManager#103

@NickCao
Copy link
Member

NickCao commented Apr 28, 2024

The changelog.md is officially depreciated thus it should be removed from meta See: GiorgosXou/TUIFIManager#103

Done

@Sigmanificient Sigmanificient added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Apr 28, 2024
@NickCao
Copy link
Member

NickCao commented Apr 28, 2024

Since this package is under the by-name hierarchy, you may use nixpkgs-merge-bot to merge it yourself. Would you like to give it a try?

@Sigmanificient
Copy link
Member

sure, @NixOS/nixpkgs-merge-bot merge

@NickCao
Copy link
Member

NickCao commented Apr 28, 2024

sure, @NixOS/nixpkgs-merge-bot merge

Try again with the exact message? Seems that it's not happy with the sure part: https://github.com/NixOS/nixpkgs-merge-bot/blob/cae47034242b6604db5199a73e5f4ce5121ffa74/nixpkgs_merge_bot/webhook/issue_comment.py#L33

@Sigmanificient
Copy link
Member

sure, @NixOS/nixpkgs-merge-bot merge

Try again with the exact message? Seems that it's not happy with the sure part: NixOS/nixpkgs-merge-bot@cae4703/nixpkgs_merge_bot/webhook/issue_comment.py#L33

Whoops!

@Sigmanificient
Copy link
Member

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

One or more checks are still pending, please retry after they are done. darwin checks can be ignored.

@NickCao
Copy link
Member

NickCao commented Apr 28, 2024

Oh we have to wait for ofborg, come back later!

@Sigmanificient
Copy link
Member

i guess we need to wait until ofborg-eval is done

@Sigmanificient
Copy link
Member

I will add support for the new dnd experimental feature in the following pr.
Already have some work done on the repository flake itself, but not sure how I should do it within nixpkgs

@NickCao
Copy link
Member

NickCao commented Apr 28, 2024

Any specific concerns other than adding a few dependencies?

@Sigmanificient
Copy link
Member

Sigmanificient commented Apr 28, 2024

Any specific concerns other than adding a few dependencies?

Since it is experimental, shouldn't be it treated in a specific way? I know some packages has boolean inputs, but i dont get how it works
Could a mechanics like this be used?

@NickCao
Copy link
Member

NickCao commented Apr 28, 2024

Any specific concerns other than adding a few dependencies?

Since it is experimental, shouldn't be it treated in a specific way? I know some packages has boolean inputs, but i dont get how it works

If the dependencies are small in size, we usually don't bother. If you want to make them conditional (only added if explicitly enabled), you can grep x11Support for examples.

@Sigmanificient
Copy link
Member

Sigmanificient commented Apr 28, 2024

Any specific concerns other than adding a few dependencies?

Since it is experimental, shouldn't be it treated in a specific way? I know some packages has boolean inputs, but i dont get how it works

If the dependencies are small in size, we usually don't bother. If you want to make them conditional (only added if explicitly enabled), you can grep x11Support for examples.

Due to the way terminal drag & drop works, it adds quite a few dependencies, including Qt
One of the experimental dependency also breaks for darwin

@ofborg ofborg bot requested a review from Sigmanificient April 28, 2024 15:44
@Sigmanificient
Copy link
Member

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot nixpkgs-merge-bot bot merged commit f2b20c3 into NixOS:master Apr 28, 2024
24 of 26 checks passed
@nixpkgs-merge-bot
Copy link
Contributor

Merge completed

@r-ryantm r-ryantm deleted the auto-update/tuifimanager branch April 29, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants