-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tuifimanager: 4.0.0 -> 4.0.5 #307438
tuifimanager: 4.0.0 -> 4.0.5 #307438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog.md
is officially depreciated thus it should be removed from meta
See: GiorgosXou/TUIFIManager#103
5de5542
to
c630ca0
Compare
Done |
Since this package is under the by-name hierarchy, you may use nixpkgs-merge-bot to merge it yourself. Would you like to give it a try? |
sure, @NixOS/nixpkgs-merge-bot merge |
Try again with the exact message? Seems that it's not happy with the |
Whoops! |
@NixOS/nixpkgs-merge-bot merge |
One or more checks are still pending, please retry after they are done. darwin checks can be ignored. |
Oh we have to wait for ofborg, come back later! |
i guess we need to wait until ofborg-eval is done |
I will add support for the new dnd experimental feature in the following pr. |
Any specific concerns other than adding a few dependencies? |
Since it is experimental, shouldn't be it treated in a specific way? I know some packages has boolean inputs, but i dont get how it works |
If the dependencies are small in size, we usually don't bother. If you want to make them conditional (only added if explicitly enabled), you can grep |
Due to the way terminal drag & drop works, it adds quite a few dependencies, including Qt |
@NixOS/nixpkgs-merge-bot merge |
Merge completed |
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for tuifimanager is: A cross-platform terminal-based termux-oriented file manager
meta.homepage for tuifimanager is: https://github.com/GiorgosXou/TUIFIManager
meta.changelog for tuifimanager is: https://github.com/GiorgosXou/TUIFIManager/blob/refs/tags/v4.0.5/CHANGELOG.md
Updates performed
To inspect upstream changes
Impact
Checks done
passthru.tests
, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }'
run on x86_64-linux 12 packages built:
Maintainer pings
cc @michaelBelsanti @Sigmanificient for testing.