puppet: init at 8.6.0 #310152
Merged
puppet: init at 8.6.0 #310152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
although unused in nixos itself, this is convenient to have puppet with a nix-shell reach. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4027 |
SuperSandro2000
approved these changes
Jun 5, 2024
SuperSandro2000
requested changes
Jun 5, 2024
pkgs/by-name/pu/puppet/package.nix
Outdated
| passthru = { | ||
| tests.version = testers.testVersion { | ||
| package = puppet; | ||
| version = (import ./gemset.nix).puppet.version; |
There was a problem hiding this comment.
Suggested change
| version = (import ./gemset.nix).puppet.version; | |
| inherit (import ./gemset.nix).puppet) version; |
| exes = [ "puppet" ]; | ||
|
|
||
| passthru = { | ||
| tests.version = testers.testVersion { |
There was a problem hiding this comment.
We probably need to set HOME to a writable directory to fix the build.
puppet --version returned a non-zero exit code.
Error: Could not initialize global default settings: Permission denied @ dir_s_mkdir - /homeless-shelter
error: builder for '/nix/store/rcd9dn8m8450a1q825k6an6imsqjf79c-puppet-8.6.0-test-version.drv' failed with exit code 1;
baloo
force-pushed
the
baloo/puppet/init-8.6.0
branch
from
0d5be2a
to
ff4bdaf
Compare
SuperSandro2000
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Puppet is a configuration language used to configure servers and laptop.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.