hare: fix mime module #311688
Merged
hare: fix mime module #311688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3932 |
ofborg
bot
added
11.by: package-maintainer
onemoresuza
force-pushed
the
hare-fix-mime-module
branch
4 times, most recently
from
2872a56
to
c286d5e
Compare
The mime module relies on the `/etc/mime.types` file. We may hardcode it like the Golang recipe[0]. Also add a `passthru.tests.mimeModule` so that we can be certain that the module is working. [0]: https://github.com/NixOS/nixpkgs/blob/f1010e0469db743d14519a1efd37e23f8513d714/pkgs/development/compilers/go/1.22.nix#L79
onemoresuza
force-pushed
the
hare-fix-mime-module
branch
from
c286d5e
to
e9ee0ff
Compare
SuperSandro2000
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The mime module relies on the
/etc/mime.typesfile. We may hardcode itlike the Golang recipe0.
Also add a
passthru.tests.mimeModuleso that we can be certain thatthe module is working.
Result of
nixpkgs-reviewrun on x86_64-linux 11 package marked as broken and skipped:
16 packages built:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.