ibus-engines.bamboo: 0.8.2-rc18 -> 0.8.4-rc3 #313316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
ofborg
bot
added
11.by: package-maintainer
nbraud
approved these changes
May 22, 2024
|
Thanks for the contribution, @goatastronaut0212 ! |
|
@SuperBo, I think your input would be welcome as well :) |
|
@nbraud, I am very happy with @goatastronaut0212 work. I don't have access to a Linux machine anymore. So I think it would be better if we can remove my name out of maintainer list and let @goatastronaut0212 be the only maintainer. |
wegank
added
the
12.approvals: 1
wegank
removed
the
12.approvals: 1
|
Can you rereview my PR again? My commit seems a little late. @nbraud I have removed @SuperBo maintainer in maintainer list from package. It is really sad to see he don't have much time and effort to continue with me, but I hope he will go well in life and thank you for his previous contribution. Your contribution really helps me a lot. |
Pandapip1
added
the
12.approvals: 1
nbraud
requested changes
May 26, 2024
nbraud
approved these changes
May 26, 2024
nbraud
force-pushed
the
update-ibus-bamboo-and-add-maintainer
branch
from
40c17fd
to
6536fbb
Compare
|
Result of 1 package built:
|
nbraud
added
12.approvals: 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Newer version will fix issue in BambooEngine/ibus-bamboo#482
I also want to become a maintainer of this package.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)