Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.11] brave: 1.65.122 -> 1.66.110 #313546

Closed
wants to merge 1 commit into from
Closed

[23.11] brave: 1.65.122 -> 1.66.110 #313546

wants to merge 1 commit into from

Conversation

buckley310
Copy link
Contributor

https://community.brave.com/t/release-channel-1-66-110/548851

Description of changes

Manually backporting #312834

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@buckley310 buckley310 marked this pull request as ready for review May 22, 2024 02:24
@buckley310 buckley310 added the 1.severity: security Issues which raise a security issue, or PRs that fix one label May 22, 2024
@ofborg ofborg bot requested review from uskudnik and rht May 22, 2024 03:02
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 22, 2024
@buckley310
Copy link
Contributor Author

Another Brave release with security patches came out today. Will open a new backport PR for the new one after it hits master.

@buckley310 buckley310 closed this May 23, 2024
@buckley310 buckley310 deleted the 2024-05-21-brave branch June 11, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uskudnik uskudnik Awaiting requested review from uskudnik

@rht rht Awaiting requested review from rht

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@buckley310