Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.05] f3d: unbreak on darwin #314499

Merged
merged 2 commits into from
May 25, 2024
Merged

[Backport release-24.05] f3d: unbreak on darwin #314499

merged 2 commits into from
May 25, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 25, 2024 •
edited by NickCao
Loading

Bot-based backport to release-24.05, triggered by a label in #313938.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

pbsds added 2 commits May 25, 2024 05:15
@pbsds @github-actions
f3d: condition autoPatchelfHook on isElf
918d095 
should fix darwin

(cherry picked from commit 67d4cea)
@pbsds @github-actions
f3d: add withManual option, by default disabled on darwin
650b371 
should fix darwin

(cherry picked from commit dc4209a)
@github-actions github-actions bot mentioned this pull request May 25, 2024
Merged
13 tasks
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 25, 2024
@ofborg ofborg bot requested review from bcdarwin and pbsds May 25, 2024 05:46
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels May 25, 2024
@NickCao NickCao merged commit ee404dc into release-24.05 May 25, 2024
21 of 22 checks passed
@bjornfor bjornfor deleted the backport-313938-to-release-24.05 branch May 25, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcdarwin bcdarwin Awaiting requested review from bcdarwin

@pbsds pbsds Awaiting requested review from pbsds

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickCao @pbsds