gnu-smalltalk: fix build #314810
Merged
gnu-smalltalk: fix build #314810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
ofborg
bot
added
10.rebuild-darwin: 0
AndersonTorres
suggested changes
May 26, 2024
GiulioCocconi
force-pushed
the
fix/smalltalk
branch
from
496745f
to
7619c96
Compare
AndersonTorres
approved these changes
May 26, 2024
|
I'd like to have the |
risicle
added
0.kind: ZHF Fixes
risicle
approved these changes
May 26, 2024
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
ZHF: #309482
The awk script incorrectly parsed
glib/glib.hand was trying to findglib/gwin32.h. I made a dirty fix by telling awk to simply ignore that file (that should be safe to do since we are only building for Linux).I don't know how to contact upstream since the bugs page on Savannah is broken.
PS: This is my first PR so please be kind ;)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.