pyfa: init at 2.60.1 #314934
pyfa: init at 2.60.1 #314934
Conversation
NixOSInfra
added
the
12. first-time contribution
ofborg
bot
added
8.has: package (new)
|
v2.59.2 released. Could this build from source? |
I can update it when i get home, we might be able to build it from source, but i have not done this, and ive heard python is a pain on nix. Can definitely look into it tho |
|
Spent some time looking into building this from source, since this is my first package and i havent really worked with python recently i couldnt get it to work. It seems to use some unconventional sourceode structure and when I got it to the point where all dependencies were installed and I thought i did everything right I couldnt find the main and all references tell me to change "my" code structure so for now I won't be doing that. |
|
Result of 1 package built:
|
There was a problem hiding this comment.
Builds fine, starts fine, but then crashes with the following error message after just a few seconds. Looks like a missing dependency at first glance.
** (pyfa.py:37703): ERROR **: 15:02:36.485: Unable to spawn a new child process: Failed to spawn child process “/usr/lib/x86_64-linux-gnu/webkit2gtk-4.0/WebKitNetworkProcess” (No such file or directory)
|
@Daholli I checked, the missing runtime dependency is Can you please add it and recommit? I would love to have pyfa as a package on NixOS. |
|
Lemme look into it, just got off work |
|
@Daholli I also just realized you didn't put yourself in there as a maintainer, which is fine if intentional, just wanna make sure. Feel free to add me as a Maintainer if needed/wanted. I use Pyfa at least once a week, so I will keep up to date with it automatically. I'm already in the maintainer file, so you can add |
|
I wasn't sure if you can be a maintainer if you are not part of the nixpkg official contributers, but yeah i can gladly add you if you want to look after it, haven't been playing much eve recently. Interesting, it has already worked before, but now i am getting a different error compared to you if I run it in an isolated environment. |
|
wth... i dunno what i just did, i built it, trying to reproduce your mistake, it worked perfectly, now I am trying to start it again and it doesnt work at all anymore, it crashes because things are missing in the graphics pipeline, probably related to me playing around with the nividia driver yesterday. I'll push it again, but is it possible for you @ToasterUwU to just finish it? |
Daholli
force-pushed
the
add-pyfa
branch
2 times, most recently
from
12186c4
to
444f618
Compare
|
Ok it still says its missing that dependency, so thats weird. I can take over if you want me too. I will just take your commits and add onto them |
|
@Daholli So i have been trying all kinds of things, and while googling around i found this issue. This seems vaguely connected, but i cant really point my finger at the right direction. Any ideas? |
|
https://github.com/Daholli/Pyfa/tree/nixos-support can you try if this works for you? I used to use this and archived it after creating the PR. Not sure why this would work, but i guess it doesn't hurt to try, and I did use this actively
|
|
@Daholli That fails in the exact same way as the pr one. |
|
Result of 1 package built:
|
|
@SuperSandro2000 Unless you have anything else, this is ready for merge now |
gepbird
added
the
12.approvals: 3+
|
Result of 1 package built:
|
|
fixing merge conflict... |
|
I still don`t get how to resolve these properly.. rebase always ends up with me having merge conflicts |
|
Result of 1 package built:
|
|
can we please merge this soon, merge conflicts are surprisingly annoying in this, not sure if I am doing something wrong |
|
@SuperSandro2000 Can you review this again now that all things have been addressed? After that please merge it if nothing is left to change |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4707 |
Description of changes
add new package: /nix/store/bq2na219yk2mnafamqiwdira8wwk42m7-pyfa-v2.58.3
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.