Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] teleport_13: remove #315182

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

justinas
Copy link
Member

@justinas justinas commented May 27, 2024

Description of changes

Backports removal of Teleport v13 from #314573 .

Teleport v13 will go out of support in June.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label May 27, 2024
@justinas justinas marked this pull request as ready for review May 27, 2024 20:17
@justinas justinas requested a review from risicle May 27, 2024 20:17
@justinas justinas added the 1.severity: security Issues which raise a security issue, or PRs that fix one label May 27, 2024
@risicle
Copy link
Contributor

risicle commented May 27, 2024

So.. the other commits were backported but not this one?

@justinas
Copy link
Member Author

So.. the other commits were backported but not this one?

I initially created the 24.05 backport in parallel with the master PR, and it was merged ahead of me implementing the removal of v13. #314578

@risicle
Copy link
Contributor

risicle commented May 27, 2024

This is one of the reasons we tend to avoid doing parallel PRs ;)

@risicle risicle merged commit 42e3277 into NixOS:release-24.05 May 27, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants