Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sgfutils: fix build on darwin #315513

Merged
merged 1 commit into from
May 29, 2024
Merged

sgfutils: fix build on darwin #315513

merged 1 commit into from
May 29, 2024

Conversation

wegank
Copy link
Member

@wegank wegank commented May 29, 2024 •
edited
Loading

Description of changes

ZHF: #309482

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 29, 2024
@afh
Copy link
Member

afh commented May 29, 2024

Result of nixpkgs-review pr 315513 run on aarch64-darwin 1

1 package built:
  • sgfutils

afh
afh approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@afh afh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity: Was iconv renamed to libiconv at some point or has this been an issue on darwin with this package all along?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1696

@ofborg ofborg bot requested a review from ggPeti May 29, 2024 05:49
@wegank wegank added the backport release-24.05 Backport PR automatically label May 29, 2024
@SuperSandro2000 SuperSandro2000 merged commit 7bc504e into NixOS:master May 29, 2024
36 of 37 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request May 29, 2024
Merged
1 task
@afh
Copy link
Member

afh commented May 29, 2024

Thanks for merging @SuperSandro, much appreciated.

@wegank wegank deleted the sgfutils-fix branch May 29, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afh afh afh approved these changes

@ggPeti ggPeti ggPeti approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 12.approvals: 2 backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wegank @afh @nixos-discourse @ggPeti @SuperSandro2000