haskellPackages: Pass ghc-options in generic-builder when cross-compiling #317181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling The following sequence of operations loses ghc-options: Setup.hs configure --ghc-options Setup.hs build --with-ghc=... This is described in [1]. The fix is simple: Don't pass --with-ghc in the build phase. The values are taken from the configure step anyway. This seems to have been introduced all the way back in 64ec4dd about 8 years ago for unknown reasons. Resolves NixOS#286285 [1]: haskell/cabal#10069
wolfgangwalther
requested review from
sternenseemann,
maralorn and
ncfavier
as code owners
ofborg
bot
added
6.topic: cross-compilation
2 tasks
sternenseemann
added
the
9.needs: port to stable
sternenseemann
added
backport staging-24.05
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following sequence of operations loses ghc-options:
This is described in 1.
The fix is simple: Don't pass --with-ghc in the build phase. The values are taken from the configure step anyway. This seems to have been introduced all the way back in 64ec4dd about 8 years ago for unknown reasons.
@sternenseemann since you're already holding fireworks in #286285, please have a look.
Things done
Built
pkgsStatic.hello.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.