Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iosevka: build from source, custom font sets #31835

Merged
merged 5 commits into from
Nov 26, 2017

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Nov 19, 2017

Motivation

Iosevka has many options to build custom font sets, but it must be built from source.

Based on #27573, but updated to build with Node 8 and support custom font sets.

Testing

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Nov 20, 2017

Note the "Details" link next to the failing "eval-package-list" check :)

@ttuegel
Copy link
Member Author

ttuegel commented Nov 20, 2017

@grahamc Thanks! Any idea why the "Details" link only appears sometimes?

jfrankenau and others added 5 commits November 20, 2017 11:07
The Iosevka builder requires Node 8, which is not supported by node2nix yet; the
included package-lock.json is processed in Nix to install the required
dependencies offline.
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 20, 2017
@grahamc
Copy link
Member

grahamc commented Nov 20, 2017 via email

@ttuegel ttuegel self-assigned this Nov 21, 2017
@ttuegel ttuegel merged commit 135835d into NixOS:master Nov 26, 2017
@orivej
Copy link
Contributor

orivej commented Nov 26, 2017

Note that this makes Iosevka unavaible on aarch64 Linux and Darwin because now it depends on otfcc which only supports x86/64 Linux.

@ttuegel
Copy link
Member Author

ttuegel commented Nov 26, 2017

otfcc which only supports x86/64 Linux.

This is a mistake; otfcc should work on any platform.

@orivej
Copy link
Contributor

orivej commented Nov 27, 2017

I've enabled building Iosevka on Darwin in 6a23fb1...f557844 . Supporting aarch64 involves an additional challenge: otfcc/premake5.lua has no provisions for this architecture. (I'm not going to take it upon myself.)

@ttuegel
Copy link
Member Author

ttuegel commented Nov 27, 2017

Supporting aarch64 involves an additional challenge: otfcc/premake5.lua has no provisions for this architecture.

This would probably be simple... except that my aarch64 board is currently out of commission. I will re-add the fetch-only expression for platforms without otfcc.

@ttuegel ttuegel deleted the iosevka/source branch November 27, 2017 12:21
@ttuegel ttuegel mentioned this pull request Nov 27, 2017
8 tasks
ttuegel added a commit to ttuegel/nixpkgs that referenced this pull request Nov 27, 2017
The former fetch-only expression is re-added as iosevka-bin to support platforms
without otfcc where Iosevka cannot be built.

See also: NixOS#31835
@AluisioASG AluisioASG mentioned this pull request Oct 30, 2020
10 tasks
AluisioASG added a commit to AluisioASG/nixpkgs that referenced this pull request Nov 4, 2020
As of Iosevka 3.7.0, otfcc is no longer used.  I haven't checked if
the situation has changed since [2017] but this should make Iosevka
available on aarch64-linux and *-darwin.

[2017]: NixOS#31835 (comment)
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 4, 2020
As of Iosevka 3.7.0, otfcc is no longer used.  I haven't checked if
the situation has changed since [2017] but this should make Iosevka
available on aarch64-linux and *-darwin.

[2017]: NixOS#31835 (comment)

(cherry picked from commit 08fd340)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants