gnome3.gsettings_desktop_schemas: do not depend on gnome-backgrounds #31991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We intend to make all GTK apps depend on the desktop schemas. Since the schemas depend on gnome-backgrounds to determine the default wallpaper path, it would increase the closure size significantly for smaller apps. We could split out the org.gnome.desktop.background and screensaver schemas but that would make the packaging unnecessarily complicated. Instead we remove the backgrounds dependency since they are not used (outside of GNOME) or they will be replaced by a different set by the NixOS module. There will be no background when running GNOME manually but that can be easily fixed.
jtojnar
added
the
6.topic: GNOME
jtojnar
changed the title
jtojnar
force-pushed
the
eschew-backrounds
branch
from
cbd5211
to
9c7a06d
Compare
|
@GrahamcOfBorg build gnome3.gsettings_desktop_schemas |
There was a problem hiding this comment.
Success for system: x86_64-darwin
make[2]: Nothing to be done for 'install-exec-am'.
/nix/store/s4sagzgijfbil29dgyxcv24pip8na49k-coreutils-8.28/bin/mkdir -p '/nix/store/xjifz5dmwv8hcyk2by8d45dns7jh70s3-gsettings-desktop-schemas-3.24.0/share/pkgconfig'
/nix/store/s4sagzgijfbil29dgyxcv24pip8na49k-coreutils-8.28/bin/install -c -m 644 gsettings-desktop-schemas.pc '/nix/store/xjifz5dmwv8hcyk2by8d45dns7jh70s3-gsettings-desktop-schemas-3.24.0/share/pkgconfig'
make[2]: Leaving directory '/private/tmp/nix-build-gsettings-desktop-schemas-3.24.0.drv-0/gsettings-desktop-schemas-3.24.0'
make[1]: Leaving directory '/private/tmp/nix-build-gsettings-desktop-schemas-3.24.0.drv-0/gsettings-desktop-schemas-3.24.0'
glibPreFixupPhase
post-installation fixup
stripping (with flags -S) in /nix/store/xjifz5dmwv8hcyk2by8d45dns7jh70s3-gsettings-desktop-schemas-3.24.0/lib
patching script interpreter paths in /nix/store/xjifz5dmwv8hcyk2by8d45dns7jh70s3-gsettings-desktop-schemas-3.24.0
/nix/store/xjifz5dmwv8hcyk2by8d45dns7jh70s3-gsettings-desktop-schemas-3.24.0
There was a problem hiding this comment.
Success for system: x86_64-linux
/nix/store/0abay33zgwqgchdzzq6h88ac4963smwf-coreutils-8.28/bin/install -c -m 644 gsettings-desktop-schemas.pc '/nix/store/r2znb4izi4snahg3l34c5j01na1z4vz9-gsettings-desktop-schemas-3.24.0/share/pkgconfig'
make[2]: Leaving directory '/tmp/nix-build-gsettings-desktop-schemas-3.24.0.drv-0/gsettings-desktop-schemas-3.24.0'
make[1]: Leaving directory '/tmp/nix-build-gsettings-desktop-schemas-3.24.0.drv-0/gsettings-desktop-schemas-3.24.0'
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/r2znb4izi4snahg3l34c5j01na1z4vz9-gsettings-desktop-schemas-3.24.0
stripping (with flags -S) in /nix/store/r2znb4izi4snahg3l34c5j01na1z4vz9-gsettings-desktop-schemas-3.24.0/lib
patching script interpreter paths in /nix/store/r2znb4izi4snahg3l34c5j01na1z4vz9-gsettings-desktop-schemas-3.24.0
checking for references to /tmp/nix-build-gsettings-desktop-schemas-3.24.0.drv-0 in /nix/store/r2znb4izi4snahg3l34c5j01na1z4vz9-gsettings-desktop-schemas-3.24.0...
/nix/store/r2znb4izi4snahg3l34c5j01na1z4vz9-gsettings-desktop-schemas-3.24.0
Could you explain the consequences in more detail? What is running GNOME manually? |
|
Basically starting it without display manager, not using the NixOS service, just installing gnome_shell and trying to run it from tty. Not sure if that would even work. |
vcunat
added a commit
that referenced
this pull request
Nov 27, 2017
do not depend on gnome-backgrounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
We intend to make all GTK apps depend on the desktop schemas (#31891). Since the schemas depend on gnome-backgrounds to determine the default wallpaper path, it would increase the closure size significantly for smaller apps.
We could split out the org.gnome.desktop.background and screensaver schemas but that would make the packaging unnecessarily complicated. Instead we remove the backgrounds dependency since they are not used (outside of GNOME) or they will be replaced by a different set by the NixOS module. There will be no background when running GNOME manually but that can be easily fixed.
See also #29766
Things done
I tested it with both GNOME 3.24 and GNOME 3.26.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)