haskell: Don't use package-qualified and non-package-qualified grep #320148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sternenseemann
approved these changes
Jun 15, 2024
maralorn
approved these changes
Jun 17, 2024
|
Or we merge this into staging… |
wegank
added
12.approvals: 2
|
I mean in the end that will likely also trigger another rebuild (unless we are careful with the timing) only advantage is it doesn’t happen on our branch. So I suggest we just wait for the merge impending merge and then merge it here. |
|
No rush from my side. It was just a drive-by cleanup. |
|
this seems like it was just forgotten, so i will ping the people involved @sternenseemann @maralorn @nh2 sorry if i was mistaken. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@ofborg build haskell.packages.ghc948.microlens |
|
Why test 948 specifically? |
|
GHC >= 9.6 needs to be rebuilt. |
sternenseemann
added
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Using
grepin 2 different ways can cause confusion and increase the closure, especially if it's not the same grep.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.