zerotierone: fix darwin build #321509
zerotierone: fix darwin build #321509
Conversation
| else | ||
| CFLAGS?=-Ofast -fstack-protector-strong | ||
| - CFLAGS+=$(ARCH_FLAGS) -Wall -flto -fPIE -mmacosx-version-min=$(MACOS_VERSION_MIN) -DNDEBUG -Wno-unused-private-field $(INCLUDES) $(DEFS) | ||
| + CFLAGS+=$(ARCH_FLAGS) -Wall -fPIE -mmacosx-version-min=$(MACOS_VERSION_MIN) -DNDEBUG -Wno-unused-private-field $(INCLUDES) $(DEFS) |
There was a problem hiding this comment.
I believe this is needed because cargo build doesn't do link time optimization, but I am unsure how to enable it.
There was a problem hiding this comment.
I am open to other suggestions, but it wouldn't be the end of the world either.
There was a problem hiding this comment.
The effect is that most object files are in bitcode format but some are not and the linker doesn't like that.
There was a problem hiding this comment.
cargo build does do lto if requested in the Cargo.toml see the cargo book. Tl;dr: set profile.release.lto = true or "thin" (where thin is faster but may achieve less performance gains).
There was a problem hiding this comment.
AFAIK no through cargo, but maybe RUSTFLAGS='-C lto=thin is enough (the lto setting in Cargo.toml does more that just set RUSTFLAGS) https://doc.rust-lang.org/cargo/reference/profiles.html#lto
ofborg
bot
added
6.topic: darwin
ofborg
bot
requested review from
obadz,
sjmackenzie,
zimbatm,
danielfullmer and
ehmry
Mic92
force-pushed
the
zerotierone-darwin
branch
from
42bca24
to
245a3c3
Compare
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.