Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.correctionlib: 2.5.0 -> 2.6.0 #321537

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Jun 21, 2024

Description of changes

Changelog: https://github.com/cms-nanoAOD/correctionlib/releases/tag/v2.6.0

Along the update, I did the following:

  • re-ordered the derivation inputs
  • switched to fetchFromGitHub

cc @veprbl

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 321537 run on aarch64-darwin 1

8 packages built:
  • python311Packages.coffea
  • python311Packages.coffea.dist
  • python311Packages.correctionlib
  • python311Packages.correctionlib.dist
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python312Packages.correctionlib
  • python312Packages.correctionlib.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 321537 run on x86_64-linux 1

8 packages built:
  • python311Packages.coffea
  • python311Packages.coffea.dist
  • python311Packages.correctionlib
  • python311Packages.correctionlib.dist
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python312Packages.correctionlib
  • python312Packages.correctionlib.dist

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 321537 run on x86_64-darwin 1

8 packages built:
  • python311Packages.coffea
  • python311Packages.coffea.dist
  • python311Packages.correctionlib
  • python311Packages.correctionlib.dist
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python312Packages.correctionlib
  • python312Packages.correctionlib.dist

@GaetanLepage GaetanLepage requested a review from veprbl June 21, 2024 15:21
@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 321537 run on aarch64-linux 1

8 packages built:
  • python311Packages.coffea
  • python311Packages.coffea.dist
  • python311Packages.correctionlib
  • python311Packages.correctionlib.dist
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python312Packages.correctionlib
  • python312Packages.correctionlib.dist

@veprbl veprbl merged commit 8c86a46 into NixOS:master Jun 22, 2024
38 checks passed
@veprbl
Copy link
Member

veprbl commented Jun 22, 2024

Thanks!

@GaetanLepage GaetanLepage deleted the correctionlib branch June 22, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants