muscle: compile with GCC for Darwin #321551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This revision updates pkgs.muscle to compile with GCC (gccStdenv instead of stdenv). This works around issues with OpenMP in the Darwin version of LLVM. The upstream Makefile assumes that we're compiling with Homebrew or similar and uses g++-11 instead of g++, so this revision also introduces a patch to remove this behavior, allowing the package to compile on Darwin without issue.
ofborg
bot
added
10.rebuild-darwin: 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This revision updates
pkgs.muscleto compile with GCC (gccStdenvinstead ofstdenv). This works around issues with OpenMP in the Darwin version of LLVM.The upstream Makefile assumes that we're compiling with Homebrew or similar and uses
g++-11instead ofg++, so this revision also introduces a patch to remove this behavior, allowing the package to compile on Darwin without issue.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.