texlive.withPackages: relax dependency resolution #321750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
6.topic: TeX
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/new-tex-live-withpackages-function/34902/22 |
ofborg
bot
added
10.rebuild-darwin: 0
The change allow swapping one package with a different one by simply passing the new package to `.withPackages`.
xworld21
force-pushed
the
texlive-deps-resolution-by-pname
branch
from
7e0f164
to
7f1a82f
Compare
ofborg
bot
added
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
and removed
10.rebuild-darwin: 0
veprbl
approved these changes
Jun 24, 2024
|
Result of 29 packages marked as broken and skipped:
15 packages failed to build:
233 packages built:
|
|
nixpkgs-review seems good... @veprbl before merging, let's wait for confirmation that |
wegank
added
the
12.approvals: 1
Oh, this is very easy to test: nix-repl> (texliveInfraOnly.withPackages (_: [ { pname = "scheme-infraonly"; } ])).requiredTeXPackages
[ ]Passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Solves the problem of replacing one package with a different version (see https://discourse.nixos.org/t/new-tex-live-withpackages-function/34902/19?u=xworld21 and preceding discussion).
This is done with two changes: first,
.withPackagesprocess its argument before the packages already included in the scheme; second, theversionattribute is dropped from the dependency resolution. Thus, replacing e.g.mintedwith a new version should be as easy asas long as
newminted.pname == texlive.pkgs.minted.pname.It is not a solid way to replace a package with another one, because it does not compose well and it is very sensitive to the order of the arguments, so I will not reference it in the documentation.
overrideScopewill be the supported way to do that kind of change, when ready.Note: this requires a
nixpkgs-reviewto ensure I did not break packages relying on.withPackages.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.