Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pymilter: 1.0.5 -> 1.0.6; replace bsddb3 with berkleydb #321940

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

yayayayaka
Copy link
Member

@yayayayaka yayayayaka commented Jun 23, 2024

Reopening #321446

Description of changes

Unbreaks pymilter after #311198.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@yayayayaka
Copy link
Member Author

Result of nixpkgs-review pr 321940 run on x86_64-linux 1

6 packages built:
  • python311Packages.pymilter
  • python311Packages.pymilter.dist
  • python312Packages.pymilter
  • python312Packages.pymilter.dist
  • spf-engine
  • spf-engine.dist

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jun 23, 2024
@ofborg ofborg bot requested a review from yorickvP June 23, 2024 11:09
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperSandro2000
Copy link
Member

@ofborg build spf-engine python312Packages.pymilter

@SuperSandro2000 SuperSandro2000 merged commit e0ba5d6 into NixOS:master Jun 23, 2024
27 of 29 checks passed
@yayayayaka yayayayaka deleted the fix-pymilter branch June 24, 2024 11:57
@pyrox0 pyrox0 added the backport release-24.05 Backport PR automatically label Jun 26, 2024
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-321940-to-release-24.05 origin/release-24.05
cd .worktree/backport-321940-to-release-24.05
git switch --create backport-321940-to-release-24.05
git cherry-pick -x ba901e926340da4cd7a684c4efcb75349fd3e09b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants