Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/plasma6: allow null password for screen lock #321944

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

K900
Copy link
Contributor

@K900 K900 commented Jun 23, 2024

Description of changes

This was fixed and we missed it, I think?

Fixes #293964, #318782

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This was fixed and we missed it, I think?
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 23, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 labels Jun 23, 2024
@NovaViper
Copy link
Contributor

Can confirm this works!

@rardiol
Copy link
Contributor

rardiol commented Jun 23, 2024

Thanks. I'm on 24.05 not unstable but setting security.pam.services.kde.allowNullPassword = true is working for me on both passwordless and passworded accounts with plasmashell 6.0.5. Since this issue negatively affects the graphical installer maybe this should be backported?

@K900 K900 merged commit fd7e20b into NixOS:master Jun 23, 2024
23 checks passed
@K900 K900 added the backport release-24.05 Backport PR automatically label Jun 23, 2024
Copy link
Contributor

Successfully created backport PR for release-24.05:

Copy link
Contributor

Git push to origin failed for release-24.05 with exitcode 1

@NovaViper
Copy link
Contributor

@rardiol Huh so that confirms it indeed wasn't a KDE issue after all then.

@K900
Copy link
Contributor Author

K900 commented Jun 23, 2024

It was a KDE issue, but it looks like the fix got backported.

NovaViper added a commit to NovaViper/NixConfig that referenced this pull request Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 backport release-24.05 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plasma 6 SDDM prompts for password despite the user not having one (NixOS ISO)
3 participants