gaphor: 2.8.2 -> 2.25.1; better-exceptions: init at 0.3.3 #322887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
|
/marvin opt-in |
JohnRTitor
changed the title
jackyliu16
reviewed
Jul 3, 2024
|
|
||
| src = fetchPypi { | ||
| inherit pname version; | ||
| sha256 = "sha256-5Oa8GERNXwTm6JSxA4Hl6SHT1UQkBBgWLH21fp6zRTs="; |
There was a problem hiding this comment.
At present, it is not recommended to use sha256 as a parameter for fetcher, but to use the hash of SRI mode as a parameter.
You could use following command to generate SRI hash.
nix hash to-sri --type sha256 $(nix-prefetch-url )
Suggested change
| sha256 = "sha256-5Oa8GERNXwTm6JSxA4Hl6SHT1UQkBBgWLH21fp6zRTs="; | |
| hash = "sha256- ... ="; |
Comment on lines
+22
to
+27
| meta = with lib; { | ||
| description = "Pretty and helpful exceptions, automatically"; | ||
| homepage = "https://github.com/qix-/better-exceptions"; | ||
| license = licenses.mit; | ||
| maintainers = [ ]; | ||
| }; |
There was a problem hiding this comment.
Currently, use with lib in meta is not recommanded anymore.
Consider to add yourself as package maintainers.
I not sure if package from pypi should add binaryNativeCode. You may consider if it should be.
Suggested change
| meta = with lib; { | |
| description = "Pretty and helpful exceptions, automatically"; | |
| homepage = "https://github.com/qix-/better-exceptions"; | |
| license = licenses.mit; | |
| maintainers = [ ]; | |
| }; | |
| meta = { | |
| description = "Pretty and helpful exceptions, automatically"; | |
| homepage = "https://github.com/qix-/better-exceptions"; | |
| license = lib.licenses.mit; | |
| sourceProvenance = with lib.sourceTypes; [ binaryNativeCode ]; | |
| maintainers = with lib.maintainers; [ ]; | |
| }; |
|
|
||
| format = "pyproject"; | ||
|
|
||
| src = fetchPypi { | ||
| inherit pname version; | ||
| sha256 = "sha256-+qqsSLjdY2I19fxdfkOEQ9DhTTHccUDll4O5yqtLiz0="; | ||
| sha256 = "sha256-9PNgU1/9RL6QXba0gn4zHCAtSV3iY0HOY1Rf6bkyzxY="; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#291281
Description of changes
Bumped version number and added/updated dependencies as needed.
Added better-exceptions as a new package because it is a dependency of gaphor.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.