Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudflare-warp: bind package location as /usr to warp-taskbar #323580

Merged
merged 1 commit into from
Jul 1, 2024
Merged

cloudflare-warp: bind package location as /usr to warp-taskbar #323580

merged 1 commit into from
Jul 1, 2024

Conversation

liff
Copy link
Contributor

@liff liff commented Jun 30, 2024

Description of changes

The warp-taskbar package wants to access /usr/share/warp/images and crashes if it does not exist. As a workaround, bind the package out path as /usr so that the process can find the image directory at the expected location.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@liff
cloudflare-warp: bind package location as /usr to warp-taskbar
b60aa1d 
The warp-taskbar package wants to access `/usr/share/warp/images` and
crashes if it does not exist. As a workaround, bind the package out
path as `/usr` so that the process can find the image directory at
the expected location.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 30, 2024
marcusramberg
marcusramberg approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@marcusramberg marcusramberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@marcusramberg marcusramberg merged commit c6f93a9 into NixOS:master Jul 1, 2024
29 checks passed
@marcusramberg marcusramberg mentioned this pull request Jul 9, 2024
Closed
@marcusramberg marcusramberg added the backport release-24.05 Backport PR automatically label Jul 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Jul 11, 2024
Merged
1 task
@marcusramberg marcusramberg mentioned this pull request Aug 11, 2024
Closed
@pxp9 pxp9 mentioned this pull request Aug 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusramberg marcusramberg marcusramberg approved these changes

@devpikachu devpikachu Awaiting requested review from devpikachu

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liff @marcusramberg