-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libreoffice, hyphen: Load hyphen dicts in LibreOffice, modularize hyphen dicts, add german hyphen dict #325290
Conversation
@Br1ght0ne for hyphen |
Yes, as described in maintainer-list.nix, but maybe I should just make everything uniform… it's not like any plausible future hosting platform is likely to have a name collision for 7c6f434c. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I want to see ofBorg builds and also if there are unexpected rev-deps for hyphen
Oh right, to add yourself as a maintainer you should also add yourself to the maintainer-list.nix |
Oh, alright! Didn't know that existed, first time contributor and all. Will have a look! |
Typo revealed by ofBorg eval error |
Oh wow, whoops. |
Description of changes
Fixes parts of #14430
Let me know if I should split this PR! I needed all these things so I added and tested them together.
hyphenDicts
that follows the same principle ashunspellDicts
(2nd commit)en_US
dict fromhyphen
and moves it tohyphenDicts.en_US
(2nd commit)de_DE
,de_CH
,de_AT
NOTE: This is a breaking change, as
hyphen
now no longer contains theen_US
dictionary.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.