Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wcurl: init at 2024.07.10 #325779

Merged
merged 1 commit into from
Jul 16, 2024
Merged

wcurl: init at 2024.07.10 #325779

merged 1 commit into from
Jul 16, 2024

Conversation

deejayem
Copy link
Member

@deejayem deejayem commented Jul 9, 2024

Description of changes

Add new package wcurl, a simple wrapper around curl for downloading files (homepage: https://salsa.debian.org/debian/wcurl , announcement: https://samueloph.dev/blog/announcing-wcurl-a-curl-wrapper-to-download-files/).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@deejayem deejayem force-pushed the add-wcurl branch 4 times, most recently from 429ae5d to 51419e3 Compare July 9, 2024 09:39
pkgs/by-name/wc/wcurl/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/wc/wcurl/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/wc/wcurl/package.nix Outdated Show resolved Hide resolved
@deejayem
Copy link
Member Author

deejayem commented Jul 9, 2024

@Sigmanificient thank you for the feedback. I think I've correctly made the changes you asked for.

pkgs/by-name/wc/wcurl/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/wc/wcurl/package.nix Outdated Show resolved Hide resolved
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 10, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4223

@lelgenio
Copy link
Contributor

Result of nixpkgs-review pr 325779 run on x86_64-linux 1

1 package built:
  • wcurl

pkgs/by-name/wc/wcurl/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/wc/wcurl/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/wc/wcurl/package.nix Outdated Show resolved Hide resolved
@deejayem deejayem changed the title wcurl: init at 2024-07-07 wcurl: init at 2024.07.10 Jul 11, 2024
@deejayem
Copy link
Member Author

@ofborg eval

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 11, 2024
@deejayem deejayem requested a review from lelgenio July 15, 2024 07:58
pkgs/by-name/wc/wcurl/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/wc/wcurl/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/wc/wcurl/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/wc/wcurl/package.nix Outdated Show resolved Hide resolved
@deejayem
Copy link
Member Author

@Aleksanaa is this better?

Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

pkgs/by-name/wc/wcurl/package.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 merged commit 0f04c04 into NixOS:master Jul 16, 2024
24 of 26 checks passed
@deejayem deejayem deleted the add-wcurl branch July 16, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants