Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update kcl to version 0.9.3 #327390

Merged
merged 3 commits into from
Jul 26, 2024
Merged

update kcl to version 0.9.3 #327390

merged 3 commits into from
Jul 26, 2024

Conversation

YvanDaSilva
Copy link
Contributor

@YvanDaSilva YvanDaSilva commented Jul 15, 2024 •
edited
Loading

Updates kcl, kclvm and kclvm_cli to v0.9.3
Also addresses macos aarch64 platform support

Description of changes

Changelog is here: https://github.com/kcl-lang/kcl/releases/tag/v0.9.3
and here: https://github.com/kcl-lang/cli/releases/tag/v0.9.3

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Tested on latest darwin and nixos, respectively aarch64 and x86_64.

@Peefy @selfuryon

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jul 15, 2024
This was referenced Jul 15, 2024
Closed
Open
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 15, 2024
@ofborg ofborg bot requested a review from selfuryon July 15, 2024 16:03
@Peefy
Copy link
Contributor

Peefy commented Jul 19, 2024

LGTM

@Peefy Peefy mentioned this pull request Jul 19, 2024
Closed
@Peefy
Copy link
Contributor

Peefy commented Jul 19, 2024

May I ask if there is a maintainer who can merge it? All tests passed. Thank you! ❤️

@YvanDaSilva
Copy link
Contributor Author

@selfuryon You are marked as a reviewer, do you have time for it?

selfuryon
selfuryon reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@selfuryon selfuryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there are already v0.9.3, maybe update all here to the latest version?

@YvanDaSilva
Copy link
Contributor Author

YvanDaSilva commented Jul 25, 2024 •
edited
Loading

@selfuryon I'll update to the latest now.

Edit:

✅ Done.

@YvanDaSilva YvanDaSilva changed the title update kcl to version v0.9.1 update kcl to version v0.9.3 Jul 25, 2024
selfuryon
selfuryon approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@selfuryon selfuryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@selfuryon selfuryon mentioned this pull request Jul 25, 2024
Closed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1856

Aleksanaa
Aleksanaa reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split into three commits, each with <package attribute name>: <old version> -> <new version>.

pkgs/by-name/kc/kclvm_cli/package.nix Outdated Show resolved Hide resolved
@YvanDaSilva
kclvm: 0.8.7 -> 0.9.3
fdb4310 
Also adds support to macos aarch64 platform
@YvanDaSilva
kclvm_cli: 0.8.7 -> 0.9.3
7201d9c 
Also adds support to macos aarch64 platform
@YvanDaSilva
kcl: 0.8.9 -> 0.9.3
cab3d18 
Also adds support to macos aarch64 platform
@ofborg ofborg bot requested a review from selfuryon July 25, 2024 16:28
@selfuryon selfuryon mentioned this pull request Jul 25, 2024
Closed
@Peefy
Copy link
Contributor

Peefy commented Jul 26, 2024

Amazing Job! 👍 LGTM!

@Aleksanaa Aleksanaa merged commit cda06cf into NixOS:master Jul 26, 2024
24 of 26 checks passed
@YvanDaSilva YvanDaSilva deleted the kcl-update branch July 26, 2024 07:53
paparodeo
paparodeo reviewed Jul 26, 2024
View reviewed changes
pkgs/by-name/kc/kcl/package.nix
nativeBuildInputs = [ makeWrapper installShellFiles ];
buildInputs = [ kclvm kclvm_cli ];
nativeBuildInputs = [ makeWrapper installShellFiles ] ++ (
lib.optionals stdenv.isDarwin [ darwin.cctools ]
Copy link
Contributor

@paparodeo paparodeo Jul 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

darwin.cctools moved to pkgs/by-name/cctools in staging and staging-next so this is created eval errors.
https://gist.github.com/GrahamcOfBorg/cc66a857ef768344f881acbbaacc32bf however, isn't cctools already part of the stdenv? Perhaps i'm missing something but it seems like all of the darwin.cctools can just be removed and not effect the build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds fine on x64 darwin removing the cctools from inputs

#330118

@paparodeo paparodeo mentioned this pull request Jul 26, 2024
Merged
13 tasks
@SuperSandro2000 SuperSandro2000 changed the title update kcl to version v0.9.3 update kcl to version 0.9.3 Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paparodeo paparodeo paparodeo left review comments

@selfuryon selfuryon selfuryon approved these changes

@Aleksanaa Aleksanaa Aleksanaa approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@YvanDaSilva @Peefy @nixos-discourse @selfuryon @Aleksanaa @paparodeo @NixOSInfra