encore: init at version 1.39.0 #328519

luisnquin · 2024-07-19T20:38:50Z

Description of changes

Things done

Add a 👍 reaction to pull requests you find important.

luisnquin · 2024-07-19T20:49:33Z

Screenshots

afh

Thanks for this, @luisnquin 🙂
Please find below a few questions and suggestions for improvement.

If you wanted to go above and beyond, please consider formatting the files using nixfmt.

afh · 2024-07-19T21:14:44Z

pkgs/by-name/en/encore/package.nix

+    name = "${pname}-source";
+    owner = "encoredev";
+    repo = pname;


Please avoid superfluous use of pname (for details see #277994)

Suggested change

name = "${pname}-source";

owner = "encoredev";

repo = pname;

name = "encore-source";

owner = "encoredev";

repo = encore;

afh · 2024-07-19T21:15:33Z

pkgs/by-name/en/encore/package.nix

+      mkdir -p $out/share/runtimes
+      cp -r $src/runtimes/* $out/share/runtimes
+
+      ln -s ${goEncore}/bin/* $out/bin


Can you check whether it is possible to use lib.getBin here, please?

Suggested change

ln -s ${goEncore}/bin/* $out/bin

ln -s ${lib.getBin goEncore}/* $out/bin

Is not possible like that.

Thanks for trying this out 👍 Not sure I understand why it doesn't work, but I'll leave that for another day 🙂

afh · 2024-07-19T21:17:49Z

pkgs/by-name/en/encore/package.nix

+  proxyVendor = true;
+
+  meta = with lib; {
+    description = "Encore is the Backend Development Platform purpose-built to help you create event-driven and distributed systems.";


The following suggestions follows recommendations for meta.description as outlined in pkgs/README.md

Suggested change

description = "Encore is the Backend Development Platform purpose-built to help you create event-driven and distributed systems.";

description = "Backend Development Platform to create event-driven and distributed systems";

afh · 2024-07-19T21:18:48Z

pkgs/by-name/en/encore/go.nix

+    owner = "encoredev";
+    repo = "go";
+    rev = "encore-go${version}";
+    sha256 = "sha256-SSa3CoUS6JMfs6T1PMb3NK8UeJnpLlTIn46/3oCTnL8=";


Use of hash is preferred over sha256 as it allows future flexibility should the hash algorithm be changed, e.g. to use sha512 instead of sha256:

Suggested change

sha256 = "sha256-SSa3CoUS6JMfs6T1PMb3NK8UeJnpLlTIn46/3oCTnL8=";

hash = "sha256-SSa3CoUS6JMfs6T1PMb3NK8UeJnpLlTIn46/3oCTnL8=";

afh · 2024-07-19T21:19:43Z

pkgs/by-name/en/encore/go.nix

+, go
+, ...
+}:
+stdenv.mkDerivation rec {


Use of finalAttrs is preferred over rec where possible. Remember to close the newly opened parenthesis at the end of the file:

Suggested change

stdenv.mkDerivation rec {

stdenv.mkDerivation (finalAttrs: {

afh · 2024-07-19T21:20:39Z

pkgs/by-name/en/encore/go.nix

+    description = "Encore's rolling fork of Go with added automatic tracing & instrumentation";
+    homepage = "https://encore.dev";
+    maintainers = with maintainers; [ luisnquin ];
+    platforms = platforms.linux;


❓ Is this really linux only?

@afh I have only tested this package on Linux.

According to https://encore.dev is should be possible to run on darwin, @luisnquin. Happy to help test on darwin if helpful…

Of course, I'm currently delivering this package in this flake first.

Just clone it, run nix build and execute the following commands:

cd "$(mktemp -d --suffix="-temp-env")" /path/to/.../result/bin/encore app create --example=url-shortener # specify project name cd <project-name> /path/to/.../result/bin/encore run

You will need to have docker available in your system.

/usr/bin/env NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1 nix build --impure github:luisnquin/nixpkgs-extra currently fails with:

trying https://github.com/encoredev/go/archive/encore-go1.22.tar.gz … curl: (22) The requested URL returned error: 404

What am I doing wrong?

I'm not sure about it, it works in my system (i have cleaned the store)

I think I have an idea what is going wrong, please allow for a few moments to verify.

afh · 2024-07-19T21:22:01Z

pkgs/by-name/en/encore/go.nix

+    '';
+
+  meta = with lib; {
+    description = "Encore's rolling fork of Go with added automatic tracing & instrumentation";


Ideally meta.description does not mention the package name, yet here it seems useful as this sub-package is tied to encore. Feel free to disregard this suggestions if it provides too little value.

Suggested change

description = "Encore's rolling fork of Go with added automatic tracing & instrumentation";

description = "Rolling fork of Go with added automatic tracing and instrumentation for use with the encore package";

afh · 2024-07-19T21:23:50Z

pkgs/by-name/en/encore/go.nix

+      mkdir -p /tmp/.gobuild-cache
+      GOCACHE=/tmp/.gobuild-cache go run . \


❓ Would this benefit from using ~~$TMPPATH~~$TMPDIR rather than /tmp directly?

Suggested change

mkdir -p /tmp/.gobuild-cache

GOCACHE=/tmp/.gobuild-cache go run . \

mkdir -p $TMPDIR/.gobuild-cache

GOCACHE=$TMPDIR/.gobuild-cache go run . \

That variable appears to be undefined on my system.

Apologies, I meant $TMPDIR.

That worked

afh · 2024-07-19T21:25:20Z

pkgs/by-name/en/encore/go.nix

+      cp -r ${goSrc} go
+      chmod -R u+rw go
+
+      cd go


Would using pushd/popd convey the intent more clearly?

Suggested change

cd go

pushd go

afh · 2024-07-19T21:25:35Z

pkgs/by-name/en/encore/go.nix

+
+      cp -p -P -v -R ../overlay/* ./
+
+      cd ..


v.s.

Suggested change

cd ..

popd

…28519

luisnquin · 2024-07-19T22:12:49Z

@afh I just applied most of the suggested changes with the nixfmt format :)

afh

Thanks for addressing the review comments and accepting the changes much appreciated 🙏

Please find below more changes that were needed in order to build this on aarch64-darwin.
With these changes does this PR still build for you on *-linux?

afh · 2024-07-19T22:16:43Z

pkgs/by-name/en/encore/go.nix

+{ fetchFromGitHub, stdenv, lib, go, ... }:
+stdenv.mkDerivation (finalAttrs: {
+  pname = "go-encore";
+  version = "1.22";


Version is missing the patch number as published on https://github.com/encoredev/go/releases/tag/encore-go1.22.0

Suggested change

version = "1.22";

version = "1.22.0";

afh · 2024-07-19T22:17:58Z

pkgs/by-name/en/encore/go.nix

+    goSrc = fetchFromGitHub {
+      owner = "golang";
+      repo = "go";
+      rev = "release-branch.go${finalAttrs.version}";


The golang repo branches do not use the patch-number, so let's strip it (see https://github.com/golang/go/tree/release-branch.go1.22):

Suggested change

rev = "release-branch.go${finalAttrs.version}";

rev = "release-branch.go${lib.versions.majorMinor finalAttrs.version}";

afh · 2024-07-19T22:21:24Z

ℹ️ Maybe I'm missing something (or nixfmt's format) has changed, but the files in this PR do not appear to be properly formatted using nixfmt…
More specifically I'd expect the input parameters on the first line to be split on one-per line.

luisnquin · 2024-07-19T22:28:17Z

@afh here are details about my nixfmt

afh · 2024-07-19T22:35:03Z

When I run nixfmt pkgs/by-name/en/encore/ changes are made to files in pkgs/by-name/en/encore/, so it appears that the changes nixfmt makes are not committed to this PRs branch.
Can you double check, please, @luisnquin?

afh · 2024-07-19T22:42:01Z

Result of nixpkgs-review pr 328519 run on aarch64-darwin 1

1 package built:

encore

😄🎉

afh · 2024-07-19T22:44:14Z

pkgs/by-name/en/encore/go.nix

+    ln -s $out/share/go/bin/go $out/bin
+    mv $out/bin/go $out/bin/go-encore


❓ Maybe I'm missing something but couldn't this be shorted to the following?

Suggested change

ln -s $out/share/go/bin/go $out/bin

mv $out/bin/go $out/bin/go-encore

ln -s $out/share/go/bin/go $out/bin/go-encore

luisnquin · 2024-07-19T22:45:11Z

@afh I'm applying those changes to the correct repository, you can see a recording in the following link https://drive.google.com/file/d/1LFn5snxJoS4tWv4acXeY4aPMc1FBmgTC/view

gss = git status -s

afh · 2024-07-19T22:50:50Z

Could it be that the latest changes containing the nixfmt changes in your workspace have not yet been pushed to this PRs branch?

afh · 2024-07-19T22:53:40Z

Re nixfmt, I was still using (and am still used to) the format from nixfmt 0.5.0 and wasn't aware 0.6.0 with changes was released. Thanks for your patience on this, @luisnquin 🙂

afh

This is shaping up nicely, @luisnquin, I think one last thing… 😬

afh · 2024-07-19T22:55:00Z

pkgs/by-name/en/encore/go.nix

+      hash = "sha256-amASGhvBcW90dylwFRC2Uj4kOAOKCgWmFKhLnA9dOgg=";
+    };
+  in ''
+    # delete submodule and replace with the go source


I think it's good practice to ensure the pre- and post- hooks are run for each phase:

Suggested change

# delete submodule and replace with the go source

runHook prePatch

# delete submodule and replace with the go source

afh · 2024-07-19T22:55:10Z

pkgs/by-name/en/encore/go.nix

+
+    cp -p -P -v -R ../overlay/* ./
+
+    popd


Suggested change

popd

popd

runHook postPatch

afh · 2024-07-19T22:55:38Z

pkgs/by-name/en/encore/go.nix

+      }.${platform.parsed.cpu.name} or (throw
+        "Unsupported system: ${platform.parsed.cpu.name}");
+  in ''
+    mkdir -p $TMPDIR/.gobuild-cache


Suggested change

mkdir -p $TMPDIR/.gobuild-cache

runHook preInstall

mkdir -p $TMPDIR/.gobuild-cache

afh · 2024-07-19T22:55:49Z

pkgs/by-name/en/encore/go.nix

+    cp -r dist/${stdenv.targetPlatform.parsed.kernel.name}_${
+      goarch stdenv.targetPlatform
+    }/encore-go/* $out/share/go
+    ln -s $out/share/go/bin/go $out/bin/go-encore


Suggested change

ln -s $out/share/go/bin/go $out/bin/go-encore

ln -s $out/share/go/bin/go $out/bin/go-encore

runHook postInstall

fmway · 2024-07-19T23:02:38Z

yo guys sorry. I just built it. But there's one tool missing (tsparser-encore).

it's here. https://github.com/encoredev/encore/blob/main/tsparser/Cargo.toml

afh · 2024-07-19T23:07:39Z

Result of nixpkgs-review pr 328519 run on aarch64-darwin 1

1 package built:

encore

afh · 2024-07-19T23:17:04Z

pkgs/by-name/en/encore/package.nix

+  doCheck = true;
+
+  subPackages =
+    [ "cli/cmd/encore" "cli/cmd/git-remote-encore" "cli/cmd/tsbundler-encore" ];


The following suggestion just 💅 feel free to disregard 🙂

Suggested change

[ "cli/cmd/encore" "cli/cmd/git-remote-encore" "cli/cmd/tsbundler-encore" ];

map (x: "cli/cmd/" + x) [ "encore" "git-remote-encore" "tsbundler-encore" ];

very nixification :v

@afh I prefer to leave it like this for now

Anyway, thanks for your suggestion

Thanks for considering it, @luisnquin.

Do I understand fmway's comment correctly that more work on this PR is necessary in order to install tsparser-encore or is this ready for final review?

@afh I'm currently trying to build tsparser-encore too but it seems that it may take me some time

Here's my current progress

I have a problem trying to get the correct hashes

nix keeps complaining about it

Oh, I think that it is no longer necessary when a lock file is passed, still, this seems somewhat tricky to maintain to me

Thanks for this, @luisnquin.

At first glance I have the following comments:

Rename the encoreSrc parameter just src

Use inherit version src; instead of assigning version and encoreSrc

A comment on the Cargo.lock operations (rm and cp) as well as on each substituteInPlace would be very helpful

Use "${lib.getExe protobuf}" instead of "${protobuf}/bin/protoc"

What will be tricky to maintain from your point of view?

At the moment, the way how the Cargo.lock file is being configured and the "subtitute in place" statements

Can you provide more context as to why they are necessary? Maybe these should be raised with upstream, unless they are specific to nixpkgs…

Because there's a lifetime error in the Rust code, I'm not sure if that only happens on Nix since I wasn't able to build it with my normal shell due to a lack of time

luisnquin · 2024-07-20T13:41:26Z

@afh by my side, the tsparser requires to update their tracing crates.

I've spent many hours on this, and if you agree, we can deliver the package in the current state until encoredev/encore#1295 is resolved. At least for now, there’s no problem using it with Go.

afh · 2024-07-20T13:53:08Z

That sounds very reasonable to me, @luisnquin, thanks for putting in the effort, much appreciated 🙏

afh

Thanks for polishing this up, well done! 👏

Find below an optional minor suggestion and feel free to disregard. Looking forward to seeing this get merged 🙂

afh · 2024-07-20T13:55:15Z

pkgs/by-name/en/encore/go.nix

+    mkdir -p $TMPDIR/.gobuild-cache
+    GOCACHE=$TMPDIR/.gobuild-cache go run . \
+      --goos "${stdenv.targetPlatform.parsed.kernel.name}" \
+      --goarch "${goarch stdenv.targetPlatform}"
+
+    mkdir -p $out/{bin,share/go}


Given that mkdir allows to create multiple directories simultaneously this could be shortened to, feel free to disregard if it hinders legibility.

Suggested change

mkdir -p $TMPDIR/.gobuild-cache

GOCACHE=$TMPDIR/.gobuild-cache go run . \

--goos "${stdenv.targetPlatform.parsed.kernel.name}" \

--goarch "${goarch stdenv.targetPlatform}"

mkdir -p $out/{bin,share/go}

mkdir -p $TMPDIR/.gobuild-cache $out/{bin,share/go}

GOCACHE=$TMPDIR/.gobuild-cache go run . \

--goos "${stdenv.targetPlatform.parsed.kernel.name}" \

--goarch "${goarch stdenv.targetPlatform}"

afh · 2024-07-20T14:00:35Z

Result of nixpkgs-review pr 328519 run on aarch64-darwin 1

1 package built:

encore

nixos-discourse · 2024-07-20T14:06:16Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1843

afh · 2024-07-22T20:27:27Z

pkgs/by-name/en/encore/package.nix

+    tsParser = callPackage ./tsparser.nix {
+      inherit src version;
+
+      runtimesPath = "${placeholder "out"}/share/runtimes";
+    };


Nice!! 👍

afh · 2024-07-22T20:28:12Z

pkgs/by-name/en/encore/tsparser.nix

+    version = version;
+
+    inherit src;


This can be shortened to:

Suggested change

version = version;

inherit src;

inherit version src;

luisnquin · 2024-07-22T20:31:00Z

@afh I just pushed new changes with the tsparser included

However @fmway you can find those changes in this flake too

afh · 2024-07-22T21:09:07Z

The latest changes on your flake worked well for me, @luisnquin, well done! Is there anything you'd like to address or are the changes in this PR ready for review from your point of view?

luisnquin · 2024-07-22T21:19:17Z

@afh yes, changes can be reviewed

afh · 2024-07-22T22:02:06Z

Result of nixpkgs-review pr 328519 run on aarch64-darwin 1

1 package built:

encore

afh

Thanks for putting in all the hard work, @luisnquin, much appreciated! From my (likely limited 😅) nixpkgs perspective things look good to me. Well done!

fredr · 2024-07-24T07:27:10Z

pkgs/by-name/en/encore/tsparser.nix

+      substituteInPlace Cargo.toml \
+        --replace 'members = ["runtimes/core", "runtimes/js", "tsparser"]' 'members = ["tsparser"]' \
+
+      substituteInPlace tsparser/src/bin/tsparser-encore.rs \


it is strange that you need to do these substitutions 🤔 what rust version is this built with?

(we always build with latest stable, so currently 1.79.0)

In the unstable channel we are at 1.78.0

Can you test that version by switching it in your local toolchain?

I tried downgrading, and I got the same issue on 1.78.0. Would it be an option to use something like fenix? they have a more up to date rust version.

Is it possible to use a flake in nixpkgs? I will research more about it.

Another option I was thinking about was to use the binaries provided by the releases that https://encore.dev/install.sh uses, at least until we can properly package with the source code.

In the current state of the package, we are not even setting the version in the binary and I'm having some problems when trying to compile a project (tsparser doesn't have a dist directory in node_modules), but if I use the binaries from the release URL I don't have a problem trying to compile a TypeScript project.

fredr · 2024-07-24T07:30:02Z

pkgs/by-name/en/encore/tsparser.nix

+
+      # to avoid to compile "broken" members
+      rm -rf runtimes
+      substituteInPlace Cargo.toml \


why do you need this substitute? is that because of the stray lock file? from what I understood it should be enough to just set buildAndTestSubdir as you do on line 30 to build a sub-package

If I remove those subtitute lines I have the following error:

I'm not a Rust expert, so if you have any ideas why that happens, I'm open.

Did you also remove the "rm -rf runtimes"? I'm wondering if it just tries to load all the Cargo.toml files from the workspace maybe

It was trying to compile every workspace member... maybe I'm doing something wrong but that was a progress while trying to package this project.

luisnquin · 2024-08-24T18:51:57Z

At least fetching from the releases we're able have binaries properly signed. This way will continously work until a perfect build is done.

If you're interested in my advance, please contact me at my email adress shared on my profile.

luisnquin self-assigned this Jul 19, 2024

luisnquin force-pushed the package/encore branch from 05a0f04 to f2db02d Compare July 19, 2024 20:46

luisnquin mentioned this pull request Jul 19, 2024

Package request: encore #327520

Open

afh suggested changes Jul 19, 2024

View reviewed changes

ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 19, 2024

luisnquin added a commit to 0xc000022070/nixpkgs-extra that referenced this pull request Jul 19, 2024

fix(encore): applied suggested changes at github:NixOS/nixpkgs/pull/3…

353d4a5

…28519

luisnquin force-pushed the package/encore branch from f2db02d to 9e837ae Compare July 19, 2024 22:12

afh suggested changes Jul 19, 2024

View reviewed changes

luisnquin force-pushed the package/encore branch from 9e837ae to 0aea8e4 Compare July 19, 2024 22:21

luisnquin force-pushed the package/encore branch from 0aea8e4 to 31a8e19 Compare July 19, 2024 22:30

afh reviewed Jul 19, 2024

View reviewed changes

luisnquin force-pushed the package/encore branch from 31a8e19 to 1ba583e Compare July 19, 2024 22:51

afh suggested changes Jul 19, 2024

View reviewed changes

luisnquin force-pushed the package/encore branch from 1ba583e to c91a870 Compare July 19, 2024 23:00

afh reviewed Jul 19, 2024

View reviewed changes

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild labels Jul 20, 2024

luisnquin mentioned this pull request Jul 20, 2024

tsparser: Cargo.lock file appears to be outdated encoredev/encore#1295

Closed

afh approved these changes Jul 20, 2024

View reviewed changes

afh added the 12.approvals: 1 label Jul 20, 2024

luisnquin force-pushed the package/encore branch 2 times, most recently from fd1187a to 57e794d Compare July 22, 2024 20:25

afh reviewed Jul 22, 2024

View reviewed changes

luisnquin force-pushed the package/encore branch 2 times, most recently from 80430e3 to d2022f8 Compare July 22, 2024 21:07

afh approved these changes Jul 22, 2024

View reviewed changes

fredr reviewed Jul 24, 2024

View reviewed changes

luisnquin marked this pull request as draft July 24, 2024 15:28

luisnquin force-pushed the package/encore branch from d2022f8 to 08ccb8f Compare August 24, 2024 18:44

encore: init at version 1.39.3

214032e

luisnquin force-pushed the package/encore branch from 08ccb8f to 214032e Compare August 24, 2024 18:48

luisnquin marked this pull request as ready for review August 24, 2024 18:52

wegank removed the 12.approvals: 1 label Sep 7, 2024

	ln -s ${goEncore}/bin/* $out/bin
	ln -s ${lib.getBin goEncore}/* $out/bin

	description = "Encore is the Backend Development Platform purpose-built to help you create event-driven and distributed systems.";
	description = "Backend Development Platform to create event-driven and distributed systems";

	sha256 = "sha256-SSa3CoUS6JMfs6T1PMb3NK8UeJnpLlTIn46/3oCTnL8=";
	hash = "sha256-SSa3CoUS6JMfs6T1PMb3NK8UeJnpLlTIn46/3oCTnL8=";

	description = "Encore's rolling fork of Go with added automatic tracing & instrumentation";
	description = "Rolling fork of Go with added automatic tracing and instrumentation for use with the encore package";

		mkdir -p /tmp/.gobuild-cache
		GOCACHE=/tmp/.gobuild-cache go run . \

	rev = "release-branch.go${finalAttrs.version}";
	rev = "release-branch.go${lib.versions.majorMinor finalAttrs.version}";

		ln -s $out/share/go/bin/go $out/bin
		mv $out/bin/go $out/bin/go-encore

	ln -s $out/share/go/bin/go $out/bin
	mv $out/bin/go $out/bin/go-encore
	ln -s $out/share/go/bin/go $out/bin/go-encore

	# delete submodule and replace with the go source
	runHook prePatch
	# delete submodule and replace with the go source

	mkdir -p $TMPDIR/.gobuild-cache
	runHook preInstall
	mkdir -p $TMPDIR/.gobuild-cache

	ln -s $out/share/go/bin/go $out/bin/go-encore
	ln -s $out/share/go/bin/go $out/bin/go-encore
	runHook postInstall

	[ "cli/cmd/encore" "cli/cmd/git-remote-encore" "cli/cmd/tsbundler-encore" ];
	map (x: "cli/cmd/" + x) [ "encore" "git-remote-encore" "tsbundler-encore" ];

encore: init at version 1.39.0 #328519

Are you sure you want to change the base?

encore: init at version 1.39.0 #328519

Conversation

luisnquin commented Jul 19, 2024 • edited Loading

Description of changes

Things done

luisnquin commented Jul 19, 2024

Screenshots

afh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afh Jul 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luisnquin commented Jul 19, 2024

afh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afh commented Jul 19, 2024

luisnquin commented Jul 19, 2024

afh commented Jul 19, 2024

afh commented Jul 19, 2024 • edited Loading

Choose a reason for hiding this comment

luisnquin commented Jul 19, 2024 • edited Loading

afh commented Jul 19, 2024

afh commented Jul 19, 2024

afh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fmway commented Jul 19, 2024

afh commented Jul 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luisnquin Jul 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luisnquin commented Jul 20, 2024

afh commented Jul 20, 2024

afh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afh commented Jul 20, 2024

nixos-discourse commented Jul 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luisnquin commented Jul 22, 2024 • edited Loading

afh commented Jul 22, 2024

luisnquin commented Jul 22, 2024

afh commented Jul 22, 2024

afh left a comment

luisnquin commented Jul 19, 2024 •

edited

Loading

afh Jul 19, 2024 •

edited

Loading

afh commented Jul 19, 2024 •

edited

Loading

luisnquin commented Jul 19, 2024 •

edited

Loading

luisnquin Jul 19, 2024 •

edited

Loading

luisnquin commented Jul 22, 2024 •

edited

Loading

luisnquin Jul 24, 2024 •

edited

Loading

luisnquin Jul 26, 2024 •

edited

Loading