calamares: 3.3.8, calamares-nixos-extensions: 0.3.18

[ElvishJerricco]

Description of changes

Waiting on NixOS/calamares-nixos-extensions#43
Fixes #322342

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[ElvishJerricco]

@DerRockWolf Can I get your review on the calamares bump? I made it into proper format-patch style patches, but I didn't remove the ActiveDirectory code like yours does in #333877 because it seems inconsequential. I'm pretty sure that's the only difference.

[vlinkz]

@DerRockWolf Can I get your review on the calamares bump? I made it into proper format-patch style patches, but I didn't remove the ActiveDirectory code like yours does in #333877 because it seems inconsequential. I'm pretty sure that's the only difference.

ActiveDirectory is disabled by default, so it shouldn't matter regardless: https://github.com/calamares/calamares/blob/v3.3.8/src/modules/users/users.conf#L272

[DerRockWolf]

Looks great, thanks.

I totally missed that you've already had a PR open ^^

[github-actions]

Successfully created backport PR for release-24.05:

• [Backport release-24.05] calamares: 3.3.8, calamares-nixos-extensions: 0.3.18 #334252

[ArtemChandragupta]

Dear contributers, can you please clarify, if this pr fixes the bug about swap partitioning during graphical installation and if it is, then it will be included in nixos iso on official website?

[DerRockWolf]

Dear contributers, can you please clarify, if this pr fixes the bug about swap partitioning during graphical installation and if it is, then it will be included in nixos iso on official website?

What "bug"? Is there any issue you can link?

Because the PR alread got back ported it will, afaik also land in the ISOs you can download on nixos.org

[ArtemChandragupta]

#322342

https://www.reddit.com/r/NixOS/s/7dPUFMZgVv

The upper issue is closed with your PR.

I have three completely different hosts (amd laptop, intel+nvidia desktop, intel laptop), all three machines can't install nixos with swap from graphical installer. It's with 24.05. When - 23.11 was released swap could been created at least on two of my machines.

Interesting, after encountering the issue I tried to install 23.11 iso that I found here, and swapon from graphical installer also crushed.

Installation from terminal works as intended.

[DerRockWolf]

#322342 is closed because this PR contains the upstream fix (NixOS/calamares-nixos-extensions#36).

So, yes creating a swap partition via the graphical installer should work again.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/security-advisory-graphical-installer-disk-encryption-bug-regression-on-legacy-bios-systems-using-manual-partitioning-ghsa-vfxf-gpmj-2p25/50665/1