Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xpra: 5.0.9 -> 6.1.2 #332295

Merged
merged 1 commit into from
Oct 3, 2024
Merged

xpra: 5.0.9 -> 6.1.2 #332295

merged 1 commit into from
Oct 3, 2024

Conversation

hxtmdev
Copy link
Member

@hxtmdev hxtmdev commented Aug 4, 2024

Description of changes

Update xpra to newest version 6.1.0

I tested seamless mode without sound with an upstream 6.1 client on Debian, I did not test the module, sound, most other features. Tests in that direction as well as a review of #279974 by people that use it would be appreciated!

breakages as per nixpkgs-review unchanged

2 packages failed to build:
xpraWithNvenc xpraWithNvenc.dist

3 packages built:
run-scaled xpra xpra.dist

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@aqrln
Copy link
Member

aqrln commented Aug 5, 2024

fix-122159.patch removed as it appears to be obsoleted by an upstream change

I'm not sure I follow, the linked commit seems to be a purely stylistic change with no change in behaviour

@hxtmdev
Copy link
Member Author

hxtmdev commented Aug 5, 2024

I'm not sure I follow, the linked commit seems to be a purely stylistic change with no change in behaviour

You are very much correct! Not sure how I managed to misread it like that. Thanks!

@aqrln
Copy link
Member

aqrln commented Aug 6, 2024

Result of nixpkgs-review pr 332295 run on aarch64-linux 1

2 packages failed to build:
  • xpraWithNvenc
  • xpraWithNvenc.dist
3 packages built:
  • run-scaled
  • xpra
  • xpra.dist

@aqrln
Copy link
Member

aqrln commented Aug 6, 2024

Sorry I didn't have time to take a look yet, will try to do it asap.

@hxtmdev
Copy link
Member Author

hxtmdev commented Aug 7, 2024

Updated to 6.1.1 from 6h ago.

@hxtmdev hxtmdev changed the title xpra: 5.0.9 -> 6.1.0 xpra: 5.0.9 -> 6.1.1 Aug 10, 2024
@hxtmdev hxtmdev changed the title xpra: 5.0.9 -> 6.1.1 xpra: 5.0.9 -> 6.1.2 Aug 26, 2024
@hxtmdev
Copy link
Member Author

hxtmdev commented Aug 26, 2024

updated to 6.1.2

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for how long this PR has languished. I was reminded of it when noticing that Xpra fails to build on staging-next due to the FFmpeg 7 upgrade, so I’m merging this now. There’s a 6.1.3 out now too which I promise to review faster if you do the bump :)

@emilazy emilazy merged commit 8532c03 into NixOS:master Oct 3, 2024
29 checks passed
@emilazy emilazy mentioned this pull request Oct 3, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants