Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcumgr-client: 0.0.4 -> 0.0.7 #332799

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Aug 6, 2024

Description of changes

At least a cargo update was required to build with Rust 1.80.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@otavio
Copy link
Contributor

otavio commented Aug 6, 2024

Result of nixpkgs-review pr 332799 run on x86_64-linux 1

1 package built:
  • mcumgr-client

@otavio
Copy link
Contributor

otavio commented Aug 8, 2024

The 0.0.7 release now includes the lock file. Are you willing to update to the latest version?

@alyssais
Copy link
Member Author

alyssais commented Aug 8, 2024

Can do.

At least a cargo update was required to build with Rust 1.80.

Cargo.lock no longer needs to be vendored, yay!

Link: rust-lang/rust#127343
This reverts commit eecd125.

The update script should work now, because upstream includes a
lockfile.
@alyssais
Copy link
Member Author

alyssais commented Aug 8, 2024

Done. I've also re-added the update script, since it should work now.

@otavio
Copy link
Contributor

otavio commented Aug 8, 2024

LGTM.

@ofborg ofborg bot requested a review from otavio August 8, 2024 19:42
@pbsds pbsds changed the title mcumgr-client: 0.0.4 -> 0.0.6 mcumgr-client: 0.0.4 -> 0.0.7 Aug 9, 2024
@alyssais alyssais merged commit 8c2c517 into NixOS:master Aug 9, 2024
31 checks passed
@alyssais alyssais deleted the mcumgr-client-0.0.6 branch August 9, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants