Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcumgr-client.updateScript: drop #332803

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Aug 6, 2024

Description of changes

This doesn't work. I think it doesn't understand the Cargo.lock being copied. All it did for me when I ran it was update the version number.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This doesn't work.  I think it doesn't understand the Cargo.lock being
copied.  All it did for me when I ran it was update the version
number.
@alyssais alyssais requested a review from otavio August 6, 2024 19:29
@otavio
Copy link
Contributor

otavio commented Aug 6, 2024

Indeed. I will talk to upstream to fix it long term.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 6, 2024
@alyssais alyssais merged commit eecd125 into NixOS:master Aug 7, 2024
24 checks passed
@alyssais alyssais deleted the mcumgr-client.updateScript branch August 7, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants