Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitrise: init at 2.19.0 #332816

Merged
merged 2 commits into from
Aug 19, 2024
Merged

bitrise: init at 2.19.0 #332816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09005f3
maintainers: add ofalvai
ofalvai Aug 10, 2024
5a558cc
bitrise: init at 2.19.0
ofalvai Aug 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions maintainers/maintainer-list.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15129,6 +15129,12 @@
githubId = 7397786;
name = "Odysseas Georgoudis";
};
ofalvai = {
email = "ofalvai@gmail.com";
github = "ofalvai";
githubId = 1694986;
name = "Olivér Falvai";
};
ofek = {
email = "oss@ofek.dev";
github = "ofek";
Expand Down
39 changes: 39 additions & 0 deletions pkgs/by-name/bi/bitrise/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{
lib,
buildGoModule,
fetchFromGitHub,
nix-update-script,
}:
buildGoModule rec {
pname = "bitrise";
version = "2.19.0";

src = fetchFromGitHub {
owner = "bitrise-io";
repo = "bitrise";
rev = version;
hash = "sha256-VjuDeRl/rqA7bdhn9REdxdjRon5WxHkFIveOYNpQqa8=";
};

# many tests rely on writable $HOME/.bitrise and require network access
doCheck = false;
Comment on lines +18 to +19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it feasible to selectively disable the network tests? Some tests are still better than none

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already have a draft PR for that, but the list of ignored tests is quite long: https://github.com/NixOS/nixpkgs/pull/333648/files#diff-6ed507756f46cf318b766f9e189a33a2c87be833e2ca6458c13b6fa43ff714dcR18

I'd rather do the clean up and refactor of the tests in the repo itself (there are distinct integration tests already, I think these failing tests should be tagged as integration tests). But I'd prefer merging this first PR with doCheck = false, and then iterate on it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fine with me 👍


vendorHash = null;
ldflags = [
"-X github.com/bitrise-io/bitrise/version.Commit=${src.rev}"
"-X github.com/bitrise-io/bitrise/version.BuildNumber=0"
];
CGO_ENABLED = 0;

passthru.updateScript = nix-update-script { };

meta = {
changelog = "https://github.com/bitrise-io/bitrise/releases";
description = "CLI for running your Workflows from Bitrise on your local machine";
homepage = "https://bitrise.io/cli";
license = lib.licenses.mit;
platforms = lib.platforms.unix;
mainProgram = "bitrise";
maintainers = with lib.maintainers; [ ofalvai ];
};
}