Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monero-{cli,gui}: 0.18.3.3 -> 0.18.3.4 #340637

Merged
merged 1 commit into from
Sep 9, 2024
Merged

monero-{cli,gui}: 0.18.3.3 -> 0.18.3.4 #340637

merged 1 commit into from
Sep 9, 2024

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Sep 9, 2024

Description of changes

Version Bump

Also:

  • Remove unnecessary dependencies

  • Fix trezor support

  • Format using nixfmt

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested connecting monero-wallet-cli to a remote node and syncronising
  • Tested compilation of all packages that depend on this change (monero-cli, monero-gui)
  • Tested basic functionality of all binary files
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@rnhmjoj
monero-{cli,gui}: 0.18.3.3 -> 0.18.3.4
473b09f 
Also:

  - Remove unnecessary dependencies

  - Fix trezor support

  - Format using nixfmt
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 9, 2024
@rnhmjoj rnhmjoj added the backport release-24.05 Backport PR automatically label Sep 9, 2024
@rnhmjoj rnhmjoj merged commit 3e6dc7b into NixOS:master Sep 9, 2024
28 of 30 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-340637-to-release-24.05 origin/release-24.05
cd .worktree/backport-340637-to-release-24.05
git switch --create backport-340637-to-release-24.05
git cherry-pick -x 473b09f778493fbba693ac6ccb17df8a7c3ab016

@prusnak prusnak mentioned this pull request Sep 9, 2024
Merged
13 tasks
@prusnak
Copy link
Member

prusnak commented Sep 9, 2024

manual backport to 24.05 in #340721

@prusnak
Copy link
Member

prusnak commented Sep 9, 2024

@rnhmjoj next time please put formatting changes in a separate commit - having version update and formatting changes in one commit makes things very hard to backport

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Sep 9, 2024

@rnhmjoj next time please put formatting changes in a separate commit - having version update and formatting changes in one commit makes things very hard to backport

Right, sorry about that. I was a bit in hurry to go to sleep after a day fighting with the monero build system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.05 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnhmjoj @prusnak