Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixVersions.nix_2_24,git: mark vulnerable #340891

Merged
merged 1 commit into from
Sep 10, 2024
Merged

nixVersions.nix_2_24,git: mark vulnerable #340891

merged 1 commit into from
Sep 10, 2024

Conversation

roberth
Copy link
Member

@roberth roberth commented Sep 10, 2024

Description of changes

Backport of #340885

(cherry picked from commit c8c6be2)
(cherry picked from commit 17bbb49)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@roberth
nixVersions.nix_2_24,git: mark vulnerable
6ba6238 
(cherry picked from commit c8c6be2)
(cherry picked from commit 17bbb49)
cole-h
cole-h approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(as mentioned in PR body) backport of #340885, let's go

@cole-h cole-h added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Sep 10, 2024
@cole-h cole-h merged commit 44a71ff into release-24.05 Sep 10, 2024
7 of 9 checks passed
@cole-h cole-h deleted the backport-nix_2_24_vulnerable branch September 10, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

@Ma27 Ma27 Awaiting requested review from Ma27

@Artturin Artturin Awaiting requested review from Artturin

@edolstra edolstra Awaiting requested review from edolstra

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roberth @cole-h